Do not include symbols nupkgs in PSB archive #47887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Member
jkoritzinsky
left a comment
jkoritzinsky
left a comment
There was a problem hiding this comment.
Could we use Exclude instead of Remove after the Include? Or does that not work correctly?
mmitche
approved these changes
Mar 26, 2025
Member
Author
I got this to work and the same model is used in other places in the codebase. I'm hesitant to do more exploration. |
jkoritzinsky
approved these changes
Mar 26, 2025
ViktorHofer
approved these changes
Mar 26, 2025
Member
Author
|
/backport to release/10.0.1xx-preview3 |
Contributor
|
Started backporting to release/10.0.1xx-preview3: https://github.com/dotnet/sdk/actions/runs/14091867245 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: dotnet/source-build#4973
This PR fixes the issue with conditioning out of symbols nupkgs when creating the PSB archive. It appears that current code never worked. This has suddenly become apparent as repo publishing process is now publishing these symbols nupkgs, even in source-build, which was not the case before. To ensure that we don't get regressed by any future publishing changes, the fix is being implemented in source-build's post-build target, and fixes the previously broken code.
This issue is unrelated to packaging of symbols in a separate archive. Symbols (PDBs) are collected using a completely different method, and not from symbols nupkgs.