Add Spectre.Console 0.52.0 #1447

jonathanpeppers · 2025-10-28T19:57:30Z

Context: #1287

We have a need again for Spectre.Console in .NET 11 (dotnet/sdk#51430).

Bringing back #1287, and addressing other issues.

Update spectre-console submodule to 0.52.0
Add patch file to delete problematic binaries:

jonathanpeppers · 2025-10-28T21:04:12Z

After mirroring Wcwidth.Sources 3.0.0 to dotnet-public, I also had to run:

./generate.sh --type text --package Wcwidth.Sources,3.0.0

MichaelSimons · 2025-10-29T13:50:46Z

/azp run source-build-reference-packages-unified-build

azure-pipelines · 2025-10-29T13:50:58Z

Azure Pipelines successfully started running 1 pipeline(s).

MichaelSimons

FYI, I triggered a run of a full unified build source-build to validate everything is working.

MichaelSimons · 2025-10-28T21:59:53Z

src/externalPackages/patches/spectre-console/0001-Remove-PolySharp.patch

Maintaining patches is non-trivial. As a follow-up I propose opening a issue/PR against Spectre.Console to see if they would be accepting of adding an msbuild property to condition this reference in order to eliminate the need for this.

It looks like they would only need PolySharp for the netstandard2.0 target framework, and we don't even build that?

I will send a PR to condition it, and see what they say.

spectreconsole/spectre.console#1934

MichaelSimons · 2025-10-29T13:45:45Z

src/externalPackages/patches/spectre-console/0002-Remove-problematic-binary-files.patch

This patch feels expensive to maintain. Any changes to these files will require regeneration of the patch. Because of the binary content, hand edits are likely off the table. What is the problem being solved here? Is this just a problem of checked in binaries?

Yes, is there a better way to do this? We could probably exclude the entire docs folder, and the build would succeed.

There are two options:

Cloak the files from the VMR. Cloaking will prevent the files from getting mirrored to the VMR. To do this you add the path(s) to https://github.com/dotnet/dotnet/blob/main/src/source-mappings.json#L89. Here is an example.

Add the binaries to allowed VMR binaries. Adding these files to https://github.com/dotnet/dotnet/blob/main/eng/allowed-vmr-binaries.txt will tell the system that these are known binaries allowed in the VMR. They will get stripped/removed when doing a source-build. If they are binaries required for source-build, then you would need to add them to https://github.com/dotnet/dotnet/blob/main/eng/allowed-sb-binaries.txt. As you mentioned they should be removed during source-builds.

If the files are sizable, I would lean towards cloaking. If they are minimal in number and size, allowed binaries feels appropriate.

I removed the patch for now, and I will send a PR to dotnet/dotnet for allowed-sb-binaries.txt. 👍

Thinking about this some more, I lean towards cloaking/excluding the entire docs folder. You will want to add that exclusion in the VMR prior to merging this PR.

yeah I think we should cloak them

Here is the PR: dotnet/dotnet#3146

jonathanpeppers · 2025-10-29T13:55:49Z

@akoeplinger I added src/externalPackages/patches/spectre-console/0002-Remove-problematic-binary-files.patch to delete the files mentioned in:

Add Spectre.Console #1287 (comment)

Are there any others I missed?

Context: dotnet/sdk#51430 Context: dotnet/source-build-reference-packages#1447 We would like to use Spectre.Console for the `dotnet` CLI, and .NET has to be able to be completely built from source. It would help us to have `PolySharp` only included when building for `netstandard2.0`, as that is the only target framework that needs the polyfills. .NET would probably only use the latest target framework. Thanks!

akoeplinger · 2025-10-29T14:47:40Z

/azp run source-build-reference-packages-unified-build

azure-pipelines · 2025-10-29T14:47:50Z

Azure Pipelines successfully started running 1 pipeline(s).

Context: dotnet/source-build-reference-packages#1447 Context: dotnet/source-build-reference-packages#1287 (comment) The docs folder contains binary files, that are not needed for building from source.

MichaelSimons · 2025-10-29T14:55:31Z

FYI, The source-build-reference-packages-unified-build leg isn't going to pass until the cloak is defined. The binary check is going to fail and block the build.

akoeplinger · 2025-10-29T15:04:09Z

ok I canceled it for now. we can retrigger it once dotnet/dotnet#3146 is merged

MichaelSimons · 2025-10-29T15:09:19Z

ok I canceled it for now. we can retrigger it once dotnet/dotnet#3146 is merged

I force merged since the source-mappings aren't validated. Let's try again.

/azp run source-build-reference-packages-unified-build

MichaelSimons · 2025-10-29T15:14:17Z

/azp run source-build-reference-packages-unified-build

azure-pipelines · 2025-10-29T15:14:28Z

Azure Pipelines successfully started running 1 pipeline(s).

jonathanpeppers · 2025-10-29T21:03:24Z

Did it fail because my PR here is from a fork? Or is there another error?

Context: dotnet#1287 * Update spectre-console submodule to 0.52.0 * Add patch file to delete problematic binaries: dotnet#1287 (comment) Co-authored-by: Jan Jones <jan.jones.cz@gmail.com>

MichaelSimons · 2025-10-29T21:24:43Z

Did it fail because my PR here is from a fork? Or is there another error?

I do not understand what the issue is. @dotnet/prodconsvcs - Can you help diagnose the sync failure here? Is this AFD related? TIA

MichaelSimons · 2025-10-29T23:19:40Z

/azp run source-build-reference-packages-unified-build

azure-pipelines · 2025-10-29T23:19:51Z

Azure Pipelines successfully started running 1 pipeline(s).

premun · 2025-10-30T09:07:59Z

/azp run source-build-reference-packages-unified-build

azure-pipelines · 2025-10-30T09:08:11Z

Azure Pipelines successfully started running 1 pipeline(s).

premun · 2025-10-30T09:54:52Z

@MichaelSimons I had no idea we're still using vmr-sync.sh somewhere. I think this is a regression because we're changing these commands a bit.
I pinned darc version for now and that should fix it for now and I will make some adjustments in arcade-services to account for using it in this way still.

akoeplinger · 2025-10-30T10:40:51Z

/__w/1/vmr/.dotnet/sdk/10.0.100-rc.1.25420.111/Roslyn/Microsoft.CSharp.Core.targets(84,5): error : Unhandled exception. Interop+Crypto+OpenSslCryptographicException: error:03000098:digital envelope routines::invalid digest [/__w/1/vmr/src/source-build-reference-packages/src/externalPackages/src/spectre-console/artifacts/clone/src/Spectre.Console/Spectre.Console.csproj::TargetFramework=net10.0]

Looks like we need to enable PublicSign so it doesn't try to do sign.

akoeplinger · 2025-10-30T10:42:15Z

/azp run source-build-reference-packages-unified-build

azure-pipelines · 2025-10-30T10:42:25Z

Azure Pipelines successfully started running 1 pipeline(s).

MichaelSimons · 2025-10-30T14:11:55Z

@MichaelSimons I had no idea we're still using vmr-sync.sh somewhere. I think this is a regression because we're changing these commands a bit. I pinned darc version for now and that should fix it for now and I will make some adjustments in arcade-services to account for using it in this way still.

I believe this is done for the optional VMR legs that can be triggered from repo PRs.
https://github.com/dotnet/dotnet/blob/main/eng/pipelines/templates/jobs/vmr-build.yml#L377

jonathanpeppers changed the title ~~Add Spectre.Console 0.52.0 (#1287)~~ Add Spectre.Console 0.52.0 Oct 28, 2025

jonathanpeppers force-pushed the dev/peppers/spectre branch from 460c488 to 87472a0 Compare October 28, 2025 21:03

jonathanpeppers force-pushed the dev/peppers/spectre branch from 87472a0 to 3831f9a Compare October 28, 2025 22:14

jonathanpeppers marked this pull request as ready for review October 29, 2025 13:53

jonathanpeppers requested a review from a team as a code owner October 29, 2025 13:53

MichaelSimons reviewed Oct 29, 2025

View reviewed changes

jonathanpeppers mentioned this pull request Oct 29, 2025

Condition PolySharp for only netstandard2.0 spectreconsole/spectre.console#1934

Open

6 tasks

jonathanpeppers mentioned this pull request Oct 29, 2025

[source build] cloak the spectre-console/docs folder dotnet/dotnet#3146

Merged

Add Spectre.Console 0.52.0 (dotnet#1287)

73a08a6

Context: dotnet#1287 * Update spectre-console submodule to 0.52.0 * Add patch file to delete problematic binaries: dotnet#1287 (comment) Co-authored-by: Jan Jones <jan.jones.cz@gmail.com>

jonathanpeppers force-pushed the dev/peppers/spectre branch from 46bb442 to 73a08a6 Compare October 29, 2025 21:24

Remove binary patch again

1dfbc3b

Pin darc version

f478334

Add DelaySign and PublicSign to build arguments

1d4b9b1

MichaelSimons approved these changes Oct 30, 2025

View reviewed changes

MichaelSimons merged commit 1a7981f into dotnet:main Oct 30, 2025
5 checks passed

dotnet-maestro bot mentioned this pull request Oct 30, 2025

[main] Source code updates from dotnet/source-build-reference-packages dotnet/dotnet#3170

Merged

Add Spectre.Console 0.52.0 #1447

Add Spectre.Console 0.52.0 #1447

Uh oh!

Conversation

jonathanpeppers commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonathanpeppers commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MichaelSimons commented Oct 29, 2025

Uh oh!

azure-pipelines bot commented Oct 29, 2025

Uh oh!

MichaelSimons left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonathanpeppers commented Oct 29, 2025

Uh oh!

akoeplinger commented Oct 29, 2025

Uh oh!

azure-pipelines bot commented Oct 29, 2025

Uh oh!

MichaelSimons commented Oct 29, 2025

Uh oh!

akoeplinger commented Oct 29, 2025

Uh oh!

MichaelSimons commented Oct 29, 2025

Uh oh!

MichaelSimons commented Oct 29, 2025

Uh oh!

azure-pipelines bot commented Oct 29, 2025

Uh oh!

jonathanpeppers commented Oct 29, 2025

Uh oh!

MichaelSimons commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MichaelSimons commented Oct 29, 2025

Uh oh!

azure-pipelines bot commented Oct 29, 2025

Uh oh!

premun commented Oct 30, 2025

Uh oh!

azure-pipelines bot commented Oct 30, 2025

Uh oh!

premun commented Oct 30, 2025

Uh oh!

akoeplinger commented Oct 30, 2025

Uh oh!

akoeplinger commented Oct 30, 2025

Uh oh!

azure-pipelines bot commented Oct 30, 2025

Uh oh!

MichaelSimons commented Oct 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

jonathanpeppers commented Oct 28, 2025 •

edited

Loading

jonathanpeppers commented Oct 28, 2025 •

edited

Loading

MichaelSimons commented Oct 29, 2025 •

edited

Loading