Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable source-build with Arcade SDK fixes #692

Merged
merged 2 commits into from Jan 19, 2021
Merged

Enable source-build with Arcade SDK fixes #692

merged 2 commits into from Jan 19, 2021

Conversation

@dagood
Copy link
Member

@dagood dagood commented Jan 14, 2021

Based on #690 with updated Arcade to get fixes/improvements.

@dagood dagood mentioned this pull request Jan 14, 2021
tmat
tmat approved these changes Jan 15, 2021
@dagood dagood marked this pull request as ready for review Jan 19, 2021
@dagood
Copy link
Member Author

@dagood dagood commented Jan 19, 2021

@tmat Are you ok merging this PR with the not-quite-rolled-out Arcade SDK official build, or would you rather wait for the official rollout?

I have a validation sourcelink official build running here to check these changes, FYI: https://dev.azure.com/dnceng/internal/_build/results?buildId=956759&view=results

@tmat
Copy link
Member

@tmat tmat commented Jan 19, 2021

I don't mind either way. Up to you.

@dagood
Copy link
Member Author

@dagood dagood commented Jan 19, 2021

Thanks, I think it's fine to go ahead. (I got mixed up and thought you had objected to merging without official auto-update in a previous PR, but I think it was a different repo.)

Green PR and validation official build. Mind doing the honors? (I don't have permissions.)

@tmat tmat merged commit 0f3cb28 into dotnet:master Jan 19, 2021
10 checks passed
@dagood dagood deleted the enable-sb branch Jan 19, 2021
omajid added a commit to omajid/dotnet-xdt that referenced this issue Feb 3, 2021
This enables 'source-build', which makes it easier to build the entire
shipping .NET SDK from source.

This is the first step of arcade-powered-source-build:
https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md

See dotnet/sourcelink#692 for a similar PR, that
this is based on.
omajid added a commit to omajid/dotnet-xdt that referenced this issue Feb 3, 2021
This enables 'source-build', which makes it easier to build the entire
shipping .NET SDK from source.

This is the first and second step of arcade-powered-source-build:
https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md

See dotnet/sourcelink#692 for a similar PR, that
this is based on.
omajid added a commit to omajid/dotnet-symreader that referenced this issue Feb 9, 2021
This enables 'source-build', which makes it easier to build the entire
shipping .NET SDK from source.

This is the first and second step of arcade-powered-source-build:
https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md

See dotnet/sourcelink#692 for a similar PR, that this is based on.
omajid added a commit to omajid/test-templates that referenced this issue Feb 10, 2021
This enables 'source-build', which makes it easier to build the entire
shipping .NET SDK from source.

This is the first and second step of arcade-powered-source-build:
https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md

See dotnet/sourcelink#692 for a similar PR, that this is based on.

Aside from arcade-specific changes, it also makes all `.sh` files
executable to make this build under Linux/macOS.

The rename from LICENSE to LICENSE.txt is a workaround for
NuGet/Home#7601.
omajid added a commit to omajid/dotnet-linker that referenced this issue Feb 10, 2021
This enables 'source-build', which makes it easier to build the entire
shipping .NET SDK from source.

This is the first and second step of arcade-powered-source-build:
https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md

See dotnet/sourcelink#692 for a similar PR, that this is based on.

The `LICENSE` to `LICENSE.txt` rename is hack to work around
NuGet/Home#7601 for now.
omajid added a commit to omajid/dotnet-linker that referenced this issue Feb 10, 2021
This enables 'source-build', which makes it easier to build the entire
shipping .NET SDK from source.

This is the first and second step of arcade-powered-source-build:
https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md

See dotnet/sourcelink#692 for a similar PR, that this is based on.

The `LICENSE` to `LICENSE.txt` rename is hack to work around
NuGet/Home#7601 for now.
omajid added a commit to omajid/dotnet-linker that referenced this issue Feb 11, 2021
This enables 'source-build', which makes it easier to build the entire
shipping .NET SDK from source.

This is the first and second step of arcade-powered-source-build:
https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md

See dotnet/sourcelink#692 for a similar PR, that this is based on.

The `LICENSE` to `LICENSE.txt` rename is hack to work around
NuGet/Home#7601 for now.
omajid added a commit to omajid/dotnet-linker that referenced this issue Feb 12, 2021
This enables 'source-build', which makes it easier to build the entire
shipping .NET SDK from source.

This is the first and second step of arcade-powered-source-build:
https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md

See dotnet/sourcelink#692 for a similar PR, that this is based on.

The `LICENSE` to `LICENSE.txt` rename is hack to work around
NuGet/Home#7601 for now.
omajid added a commit to omajid/dotnet-linker that referenced this issue Feb 12, 2021
This enables 'source-build', which makes it easier to build the entire
shipping .NET SDK from source.

This is the first and second step of arcade-powered-source-build:
https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md

See dotnet/sourcelink#692 for a similar PR, that this is based on.

The `LICENSE` to `LICENSE.txt` rename is hack to work around
NuGet/Home#7601 for now.
omajid added a commit to omajid/dotnet-linker that referenced this issue Feb 16, 2021
This enables 'source-build', which makes it easier to build the entire
shipping .NET SDK from source.

This is the first and second step of arcade-powered-source-build:
https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md

See dotnet/sourcelink#692 for a similar PR, that this is based on.

The `LICENSE` to `LICENSE.txt` rename is hack to work around
NuGet/Home#7601 for now.
omajid added a commit to omajid/dotnet-linker that referenced this issue Feb 16, 2021
This enables 'source-build', which makes it easier to build the entire
shipping .NET SDK from source.

This is the first and second step of arcade-powered-source-build:
https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md

See dotnet/sourcelink#692 for a similar PR, that this is based on.

The `LICENSE` to `LICENSE.txt` rename is hack to work around
NuGet/Home#7601 for now.
omajid added a commit to omajid/dotnet-linker that referenced this issue Feb 16, 2021
This enables 'source-build', which makes it easier to build the entire
shipping .NET SDK from source.

This is the first and second step of arcade-powered-source-build:
https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md

See dotnet/sourcelink#692 for a similar PR, that this is based on.

The `LICENSE` to `LICENSE.txt` rename is hack to work around
NuGet/Home#7601 for now.
omajid added a commit to omajid/dotnet-command-line-api that referenced this issue Feb 16, 2021
This enables 'source-build', which makes it easier to build the entire
shipping .NET SDK from source.

This is the first and second step of arcade-powered-source-build:
https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md

See dotnet/sourcelink#692 for a similar PR, that this is based on.
omajid added a commit to omajid/dotnet-symreader that referenced this issue Feb 18, 2021
This enables 'source-build', which makes it easier to build the entire
shipping .NET SDK from source.

This is the first and second step of arcade-powered-source-build:
https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md

See dotnet/sourcelink#692 for a similar PR, that this is based on.
omajid added a commit to omajid/dotnet-symreader that referenced this issue Feb 18, 2021
This enables 'source-build', which makes it easier to build the entire
shipping .NET SDK from source.

This is the first and second step of arcade-powered-source-build:
https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md

See dotnet/sourcelink#692 for a similar PR, that this is based on.
tmat pushed a commit to dotnet/symreader that referenced this issue Feb 18, 2021
This enables 'source-build', which makes it easier to build the entire
shipping .NET SDK from source.

This is the first and second step of arcade-powered-source-build:
https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md

See dotnet/sourcelink#692 for a similar PR, that this is based on.
omajid added a commit to omajid/dotnet-xdt that referenced this issue Feb 24, 2021
This enables 'source-build', which makes it easier to build the entire
shipping .NET SDK from source.

This is the first and second step of arcade-powered-source-build:
https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md

See dotnet/sourcelink#692 for a similar PR, that
this is based on.
omajid added a commit to omajid/dotnet-xdt that referenced this issue Mar 3, 2021
This enables 'source-build', which makes it easier to build the entire
shipping .NET SDK from source.

This is the first and second step of arcade-powered-source-build:
https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md

See dotnet/sourcelink#692 for a similar PR, that
this is based on.
omajid added a commit to omajid/dotnet-command-line-api that referenced this issue Mar 8, 2021
This enables 'source-build', which makes it easier to build the entire
shipping .NET SDK from source.

This is the first and second step of arcade-powered-source-build:
https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md

See dotnet/sourcelink#692 for a similar PR, that this is based on.

And try and resolve some nullability errors.

For source-build, sisable warnings so we can build this without
extensive customizations, since we update the TFM ourselves.
jonsequitur added a commit to dotnet/command-line-api that referenced this issue Mar 8, 2021
This enables 'source-build', which makes it easier to build the entire
shipping .NET SDK from source.

This is the first and second step of arcade-powered-source-build:
https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md

See dotnet/sourcelink#692 for a similar PR, that this is based on.

And try and resolve some nullability errors.

For source-build, sisable warnings so we can build this without
extensive customizations, since we update the TFM ourselves.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants