Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the new GitLab raw url #713

Merged
merged 1 commit into from Aug 16, 2021

Conversation

@dnfadmin
Copy link

@dnfadmin dnfadmin commented Apr 24, 2021

CLA assistant check
All CLA requirements met.

@rgl
Copy link
Contributor Author

@rgl rgl commented Apr 24, 2021

Please review the TODOs and let me known how they should be handled.

@tmat
Copy link
Member

@tmat tmat commented Aug 12, 2021

@rgl Sorry for the delay of my review. Was busy with other things.

If you're still interested in finishing this PR please rebase and rerun tests and make sure all pass. We also need a new test that validates the usage of the Version metadata.

@tmat
Copy link
Member

@tmat tmat commented Aug 12, 2021

BTW, is there some kind of release note from GitLab that announces the change in URL format?

@rgl
Copy link
Contributor Author

@rgl rgl commented Aug 15, 2021

BTW, is there some kind of release note from GitLab that announces the change in URL format?

Doing a bit of history browsing, I came up with:

  1. https://gitlab.com/gitlab-org/gitlab-foss/-/blob/v14.1.2/config/routes/repository_deprecated.rb#L29: where they are handling the deprecated routes.
  2. https://gitlab.com/gitlab-org/gitlab/-/issues/28848: where they mention that project routes were deprecated in 12.0.

@rgl rgl force-pushed the add-new-gitlab-sourcelink-raw-address branch 2 times, most recently from 2b41d82 to b6f2c4a Aug 15, 2021
@rgl rgl force-pushed the add-new-gitlab-sourcelink-raw-address branch from b6f2c4a to 7cb315c Aug 15, 2021
@rgl
Copy link
Contributor Author

@rgl rgl commented Aug 15, 2021

@tmat, this is now ready for review.

Please note that I'm assuming the URL change happened at GitLab 12.0. I didn't actually test it with that version, because I was not able to install such an old GitLab release locally.

tmat
tmat approved these changes Aug 16, 2021
Copy link
Member

@tmat tmat left a comment

:shipit:

@tmat
Copy link
Member

@tmat tmat commented Aug 16, 2021

@rgl Looks great now. Thanks for the PR!

@tmat tmat merged commit 9dab778 into dotnet:main Aug 16, 2021
10 checks passed
@tmat tmat added this to the 1.1.0 milestone Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants