Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to v3 publishing #737

Merged
merged 1 commit into from Aug 17, 2021
Merged

Move to v3 publishing #737

merged 1 commit into from Aug 17, 2021

Conversation

@adiaaida
Copy link
Member

@adiaaida adiaaida commented Aug 16, 2021

No description provided.

@adiaaida
Copy link
Member Author

@adiaaida adiaaida commented Aug 16, 2021

tmat
tmat approved these changes Aug 16, 2021
@tmat
Copy link
Member

@tmat tmat commented Aug 16, 2021

Thanks!

@tmat
Copy link
Member

@tmat tmat commented Aug 16, 2021

@adiaaida @mmitche Should #729 also have been updated with the latest Arcade version? Seems like it hasn't been updated in a week.

@adiaaida
Copy link
Member Author

@adiaaida adiaaida commented Aug 16, 2021

I don't know if we have promoted arcade since that was last updated. It looks like it has the same arcade sdk version as what is currently in arcade itself: https://github.com/dotnet/arcade/blob/main/global.json#L6

@adiaaida
Copy link
Member Author

@adiaaida adiaaida commented Aug 16, 2021

Also, I don't have merge rights, so whenever tests complete, @tmat would you mind completing this PR for me?

@tmat tmat merged commit eb50191 into dotnet:main Aug 17, 2021
10 checks passed
@@ -153,6 +153,7 @@ stages:
- ${{ if and(ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'PullRequest')) }}:
- template: eng\common\templates\post-build\post-build.yml
parameters:
publishingInfraVersion: 3
Copy link
Member

@danmoseley danmoseley Aug 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed the issue mentioned in the line below was resolved 2 years ago. @JohnTortugo
dotnet/arcade#2871

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants