Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flesh out "multi-packages" #688

Closed
ericstj opened this Issue Mar 21, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@ericstj
Copy link
Member

ericstj commented Mar 21, 2018

In the fix for #680 I added special behavior for "multi-packages" where they can be treated as trimmable until all assets are included.

This works well in the case of a package that's multiple dlls, but what about:

  1. Single DLL + content
  2. Single DLL + native dll(s)
  3. Many DLL + content

For 1 I don't think we should consider it a multi-package: nothing will typically root content and we don't want to trim it.
For 2 I don't think we should consider it a multi-package, though in the common case we'll probably still identify roots to the native DLLs through DllImport probing.
For 3 we almost need a special case where we will root the content but not the other DLLs. Alternatively we could punt on this and force folks to root the packages.

@ericstj ericstj added the enhancement label Mar 21, 2018

@ericstj ericstj self-assigned this Mar 21, 2018

@terrajobst terrajobst added the tools label Oct 17, 2018

@ericstj ericstj closed this Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.