Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Packaging] Specify placeholders for lib folders #85

Closed
terrajobst opened this Issue Oct 26, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@terrajobst
Copy link
Member

terrajobst commented Oct 26, 2016

From the packaging spec:

  • tools/net461
    • Contains a single netstandard.targets file that provides reference items
      to all the facades
    • Contains netstandard facade, type forwarding to mscorlib.dll
    • Contains System.Runtime-based facades, type forwarding to mscorlib.dll

@weshaggard said:

We should call out what is going in the lib folders as well, which are mostly just placeholders.

@ericstj, can you help with that?

@terrajobst terrajobst changed the title Specify placeholders for lib folders [Packaging] Specify placeholders for lib folders Oct 26, 2016

@ericstj

This comment has been minimized.

Copy link
Member

ericstj commented Oct 26, 2016

Sure, do you have the notes from our meetings? IIRC the rules we had for the NETStandard.Library package were as follows:

  • lib\netstandardX - reference assembly for netstandard.dll, facades for mscorlib++ & system.runtime++ on top of netstandard.dll
  • lib\<tfm>\_._ - for every <tfm> that supports netstandardX to ensure NETStandard.Library never provides any assets for frameworks supporting netstandard.
  • tools\<tfm>' - for everythat supportsnetstandardXbut cannot be updated to include support fornetstandardXinbox. Contains targets and facades to adapt bothnetstandard.dll` and any out-of-box contracts (eg: System.IO.FileSystem, etc) to the inbox reference assemblies (eg: mscorlib).

I use lib here instead of ref to ensure that this will work with packages.config. One of the dangers with using lib is that it creates copy-local references. We may want to see if we can come up with a technique for ensuring those aren't copy-local.

@weshaggard weshaggard added the packaging label Dec 2, 2016

@weshaggard weshaggard assigned terrajobst and unassigned ericstj Mar 30, 2017

@weshaggard weshaggard added documentation and removed packaging labels Mar 30, 2017

@weshaggard

This comment has been minimized.

Copy link
Member

weshaggard commented Mar 30, 2017

We landed on using targets files to add references so there isn't ever anything in the lib folders or ref folders for NETStandard.Library 2.0+ packages.

@terrajobst I will leave this issue assigned to you for updating the documentation.

@terrajobst

This comment has been minimized.

Copy link
Member Author

terrajobst commented Mar 13, 2019

Since this has happened I'm closing.

@terrajobst terrajobst closed this Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.