Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

Miscellaneous improvements in System.Net.* #827

Merged
merged 1 commit into from Oct 23, 2018
Merged

Miscellaneous improvements in System.Net.* #827

merged 1 commit into from Oct 23, 2018
+445 −24

Conversation

terrajobst
Copy link
Member

@terrajobst terrajobst commented Jul 16, 2018 •
edited

This also fixes #772 and fixes #852.

@dotnet/nsboard

@terrajobst terrajobst added the netstandard-api This tracks requests for standardizing APIs. label Jul 16, 2018
@terrajobst terrajobst added this to the .NET Standard vNext milestone Jul 16, 2018
marek-safar
marek-safar previously requested changes Jul 25, 2018
View reviewed changes
netstandard/ref/System.Net.NetworkInformation.cs Outdated Show resolved Hide resolved
netstandard/ref/System.Net.WebSockets.cs Outdated Show resolved Hide resolved
netstandard/ref/System.Net.cs Show resolved Hide resolved
netstandard/ref/System.Net.cs Outdated Show resolved Hide resolved
weshaggard
weshaggard previously requested changes Jul 26, 2018
View reviewed changes
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to have a closer review of this diff as there are a lot of things we should not include.

@weshaggard
Copy link
Member

@davidsh @karelz please take a look at the proposed API additions for the next version of .NET Standard in the networking space. These are APIs that are in .NET Core 2.1 but weren't part of .NET Standard so please call out any that you don't think should be added to the standard.

davidsh
davidsh reviewed Jul 26, 2018
View reviewed changes
Copy link

@davidsh davidsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this. I commented on a few things and upvoted others.

@bartonjs bartonjs mentioned this pull request Aug 14, 2018
Closed
UltzLtd pushed a commit to Ultz/SimpleServer that referenced this pull request Aug 27, 2018
@Perksey
Restrict HTTPS functionality to .NET Core 2.1, target .NET Standard
3f533f1 
dotnet/standard#852 dotnet/standard#852
dotnet/standard#827 dotnet/standard#827
@terrajobst terrajobst requested review from a team and removed request for a team October 15, 2018 17:16
@terrajobst terrajobst dismissed stale reviews from weshaggard and marek-safar October 15, 2018 18:05

stale

@terrajobst
Copy link
Member Author

terrajobst commented Oct 15, 2018 •
edited

I believe I've addressed all feedback. Ready to go?

@terrajobst terrajobst changed the base branch from master-with-span to span October 16, 2018 02:31
@terrajobst terrajobst added the * NO MERGE * Applied to pull-requests that aren't ready to be merged yet. label Oct 16, 2018
@terrajobst terrajobst requested a review from a team October 17, 2018 22:01
@terrajobst terrajobst requested a review from a team as a code owner October 20, 2018 22:41
@terrajobst terrajobst removed the request for review from a team October 22, 2018 16:14
marek-safar
marek-safar suggested changes Oct 22, 2018
View reviewed changes
netstandard/ref/System.Net.Security.cs Outdated Show resolved Hide resolved
netstandard/ref/System.Net.Sockets.cs Outdated Show resolved Hide resolved
netstandard/ref/System.Net.Sockets.cs Outdated Show resolved Hide resolved
netstandard/ref/System.Net.cs Show resolved Hide resolved
@terrajobst
Copy link
Member Author

@marek-safar

I've removed the StructLayoutAttribute applications. Good to go now?

@terrajobst terrajobst changed the base branch from span to master October 22, 2018 20:22
@terrajobst terrajobst removed the * NO MERGE * Applied to pull-requests that aren't ready to be merged yet. label Oct 22, 2018
@terrajobst terrajobst merged commit 895ece6 into dotnet:master Oct 23, 2018
@terrajobst terrajobst deleted the system-net branch October 23, 2018 20:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@karelz karelz karelz approved these changes

@davidsh davidsh davidsh left review comments

@Perksey Perksey Perksey left review comments

@joshpeterson joshpeterson joshpeterson approved these changes

@jaredpar jaredpar jaredpar approved these changes

@marek-safar marek-safar marek-safar approved these changes

@clairernovotny clairernovotny clairernovotny approved these changes

@weshaggard weshaggard weshaggard approved these changes

Assignees
No one assigned
Labels
netstandard-api This tracks requests for standardizing APIs.
Projects
None yet
Milestone
.NET Standard 2.1
Development

Successfully merging this pull request may close these issues.

SslStream ALPN support [Question] New HttpStatusCodes
9 participants
@terrajobst @weshaggard @joshpeterson @jaredpar @marek-safar @clairernovotny @karelz @davidsh @Perksey