Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet new giraffe fails after latest update #1373

Closed
livarcocc opened this issue Dec 17, 2017 · 5 comments
Closed

dotnet new giraffe fails after latest update #1373

livarcocc opened this issue Dec 17, 2017 · 5 comments

Comments

@livarcocc
Copy link
Contributor

@livarcocc livarcocc commented Dec 17, 2017

From @dustinmoris on December 16, 2017 22:27

Steps to reproduce

dotnet new giraffe

or as @cartermp demo'd in his blog post:

dotnet new giraffe -o GiraffeSample

Expected behavior

The CLI should identify that the giraffe template only supports F# as language and therefore successfully create an F# Giraffe application without asking the user to specify the additional -lang parameter.

Actual behavior

The command fails and shows help for dotnet new. This is a regression bug as it worked as expected in previous versions.

Environment data

dotnet --info output:

.NET Command Line Tools (2.0.3)

Product Information:
 Version:            2.0.3
 Commit SHA-1 hash:  eb1d5ee318

Runtime Environment:
 OS Name:     Mac OS X
 OS Version:  10.13
 OS Platform: Darwin
 RID:         osx.10.12-x64
 Base Path:   /usr/local/share/dotnet/sdk/2.0.3/

Microsoft .NET Core Shared Framework Host

  Version  : 2.0.3
  Build    : a9190d4a75f4a982ae4b4fa8d1a24526566c69df

Copied from original issue: dotnet/cli#8257

@lambdakris
Copy link
Contributor

@lambdakris lambdakris commented Dec 19, 2017

Would like to clarify that this affects any template that by default supports any .NET language other than C#. Two immediate examples that come to mind are the templates for Giraffe and the SAFE Stack. Both have dotnet cli templates that at the moment do not work unless the language option for F# is supplied. The Giraffe repo already has two issues related to this: giraffe-fsharp/Giraffe#173, giraffe-fsharp/Giraffe#170.

...also, what is the thinking around letting devs change the default language at the CLI level so that -lang f# or -lang vb gets used automatically and F# and VB devs don't have to always type out the lang option for multi-lang templates. I think I remember mention of this in the early days, wondering if this is still viable...

@mlorbetske
Copy link
Contributor

@mlorbetske mlorbetske commented Dec 21, 2017

Fixed with PR #1375

@csmager
Copy link

@csmager csmager commented Jan 15, 2018

I'm running into this issue in 2.1.4... has this fix been shipped?

@mlorbetske
Copy link
Contributor

@mlorbetske mlorbetske commented Jan 16, 2018

@csmager this fix will ship in the CLI that carries the first preview of the 2.1.0 runtime

@csmager
Copy link

@csmager csmager commented Jan 16, 2018

Thanks - was evidently confused by SDK vs runtime versions! Glad it's not something I'm doing wrong...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.