System.ArgumentException: '(,4)' is not a valid version string

[suchoss]

Hello,

first of all - great work. I tried current version of dotnet tools and it looks it works (with most projects in our solution) on our big old project.

Used tools versions:

try-convert            0.7.216201      try-convert
upgrade-assistant      0.2.217201      upgrade-assistant

Problematic project:
https://github.com/HlidacStatu/HlidacStatu/blob/master/Web.Statu/Web.csproj

It can't go past step 3. [Failed] Clean up NuGet package references. It ends with following error:

[12:19:42 INF] Initializing upgrade step Clean up NuGet package references
[12:19:51 FTL] Unexpected exception analyzing package references for: D:\repos\gardohundo\HlidacStatu\Web.Statu\Web.csproj
System.ArgumentException: '(,4)' is not a valid version string. (Parameter 'value')
   at NuGet.Versioning.NuGetVersion.Parse(String value)
   at Microsoft.DotNet.UpgradeAssistant.Steps.Packages.Analyzers.TransitiveDependencyExtensions.ReferenceSatisfiesDependency(PackageDependency dependency, NuGetReference packageReference, Boolean minVersionMatchOnly) in /_/src/steps/Microsoft.DotNet.UpgradeAssistant.Steps.Packages/Analyzers/TransitiveDependencyExtensions.cs:line 32
   at System.Linq.Enumerable.Any[TSource](IEnumerable`1 source, Func`2 predicate)
   at System.Linq.Enumerable.Any[TSource](IEnumerable`1 source, Func`2 predicate)
   at Microsoft.DotNet.UpgradeAssistant.Steps.Packages.Analyzers.TransitiveReferenceAnalyzer.AnalyzeAsync(IProject project, PackageAnalysisState state, CancellationToken token) in /_/src/steps/Microsoft.DotNet.UpgradeAssistant.Steps.Packages/Analyzers/TransitiveReferenceAnalyzer.cs:line 31
   at Microsoft.DotNet.UpgradeAssistant.Steps.Packages.PackageUpdaterStep.RunPackageAnalyzersAsync(IUpgradeContext context, CancellationToken token) in /_/src/steps/Microsoft.DotNet.UpgradeAssistant.Steps.Packages/PackageUpdaterStep.cs:line 206
   at Microsoft.DotNet.UpgradeAssistant.Steps.Packages.PackageUpdaterStep.InitializeImplAsync(IUpgradeContext context, CancellationToken token) in /_/src/steps/Microsoft.DotNet.UpgradeAssistant.Steps.Packages/PackageUpdaterStep.cs:line 136

The problem is in https://github.com/HlidacStatu/HlidacStatu/blob/master/Web.Statu/packages.config

  <package id="bootstrap" version="3.4.1" targetFramework="net472" allowedVersions="(,4)" />
  <package id="bootstrap.less" version="3.4.1" targetFramework="net472" allowedVersions="(,4)" />

and another problem in the same file is with following:

<package id="Microsoft.AspNet.TelemetryCorrelation" version="1.0.7" targetFramework="net472" allowedVersions="[1.0.7]" />

Generally packages with allowedVersions attribute are causing fails when being converted.

Thanks a lot!

[twsouthwick]

Good catch! Looks like our version parsing is working in packages.config.

[sunandabalu]

@mjrousos PTAL

[mjrousos]

Sounds like a bug. I'll check it out.

[brandonh-msft]

Unable to repro in latest rev of the tool.

Upgrade Steps

Entrypoint: C:\s\t\HlidacStatu\Web.Statu\Web.csproj
Current Project: C:\s\t\HlidacStatu\Web.Statu\Web.csproj

1. [Complete] Back up project
2. [Complete] Convert project file to SDK style
3. Clean up NuGet package references
    a. [Complete] Duplicate reference analyzer
        1. [Complete] Remove package 'System.Runtime.Caching'
    b. [Complete] Package map reference analyzer
        1. [Complete] Remove reference 'System.Configuration'
        2. [Complete] Remove package 'Microsoft.Net.Http'
        3. [Complete] Add package 'System.Net.Http'
    c. [Complete] Target compatibility reference analyzer
    d. [Complete] Upgrade assistant reference analyzer
        1. [Complete] Add package 'Microsoft.DotNet.UpgradeAssistant.Extensions.Default.Analyzers'
    e. [Complete] Windows Compatibility Pack Analyzer
    f. [Complete] MyDotAnalyzer reference analyzer
    g. [Complete] Newtonsoft.Json reference analyzer
    h. [Complete] Windows App SDK package analysis
    i. Transitive reference analyzer

LMK if you find otherwise, though