From 98f704317c2e4842ac3ab3516d971706ebbce977 Mon Sep 17 00:00:00 2001 From: Andrew Wang Date: Mon, 13 Mar 2017 14:26:05 -0700 Subject: [PATCH 1/4] Adding quoteArgs flag --- package.json | 10 ++++++++++ src/tools/OptionsSchema.json | 5 +++++ 2 files changed, 15 insertions(+) diff --git a/package.json b/package.json index f5f802bac7..4b59f2fcbd 100644 --- a/package.json +++ b/package.json @@ -727,6 +727,11 @@ "description": "Environment variables passed to the pipe program.", "default": {} }, + "quoteArgs": { + "type": "boolean", + "description": "Flag to enable or disable quotes around 'debuggerPath'", + "default": true + }, "windows": { "description": "Windows-specific pipe launch configuration options", "default": { @@ -975,6 +980,11 @@ "description": "Environment variables passed to the pipe program.", "default": {} }, + "quoteArgs": { + "type": "boolean", + "description": "Flag to enable or disable quotes around 'debuggerPath'", + "default": true + }, "windows": { "description": "Windows-specific pipe launch configuration options", "default": { diff --git a/src/tools/OptionsSchema.json b/src/tools/OptionsSchema.json index 68a8a3ed62..cb09910b0b 100644 --- a/src/tools/OptionsSchema.json +++ b/src/tools/OptionsSchema.json @@ -84,6 +84,11 @@ "description": "Environment variables passed to the pipe program.", "default": {} }, + "quoteArgs": { + "type": "boolean", + "description": "Flag to enable or disable quotes around 'debuggerPath'", + "default": true + }, "windows": { "$ref": "#/definitions/PipeConfigurations", "description": "Windows-specific pipe launch configuration options", From 73b2e27fb13644e7222a8ba8a613abcc7e6f7e39 Mon Sep 17 00:00:00 2001 From: Andrew Wang Date: Mon, 13 Mar 2017 18:22:09 -0700 Subject: [PATCH 2/4] Adding QuoteArgs to PipeConfiguration --- package.json | 30 ++++++++++++++++++++++++++++++ src/tools/OptionsSchema.json | 5 +++++ 2 files changed, 35 insertions(+) diff --git a/package.json b/package.json index 4b59f2fcbd..90bd062911 100644 --- a/package.json +++ b/package.json @@ -759,6 +759,11 @@ }, "default": [] }, + "quoteArgs": { + "type": "boolean", + "description": "Flag to enable or disable quotes around 'debuggerPath'", + "default": true + }, "pipeEnv": { "type": "object", "additionalProperties": { @@ -796,6 +801,11 @@ }, "default": [] }, + "quoteArgs": { + "type": "boolean", + "description": "Flag to enable or disable quotes around 'debuggerPath'", + "default": true + }, "pipeEnv": { "type": "object", "additionalProperties": { @@ -833,6 +843,11 @@ }, "default": [] }, + "quoteArgs": { + "type": "boolean", + "description": "Flag to enable or disable quotes around 'debuggerPath'", + "default": true + }, "pipeEnv": { "type": "object", "additionalProperties": { @@ -1012,6 +1027,11 @@ }, "default": [] }, + "quoteArgs": { + "type": "boolean", + "description": "Flag to enable or disable quotes around 'debuggerPath'", + "default": true + }, "pipeEnv": { "type": "object", "additionalProperties": { @@ -1049,6 +1069,11 @@ }, "default": [] }, + "quoteArgs": { + "type": "boolean", + "description": "Flag to enable or disable quotes around 'debuggerPath'", + "default": true + }, "pipeEnv": { "type": "object", "additionalProperties": { @@ -1086,6 +1111,11 @@ }, "default": [] }, + "quoteArgs": { + "type": "boolean", + "description": "Flag to enable or disable quotes around 'debuggerPath'", + "default": true + }, "pipeEnv": { "type": "object", "additionalProperties": { diff --git a/src/tools/OptionsSchema.json b/src/tools/OptionsSchema.json index cb09910b0b..82d0d0aea2 100644 --- a/src/tools/OptionsSchema.json +++ b/src/tools/OptionsSchema.json @@ -32,6 +32,11 @@ }, "default": [] }, + "quoteArgs": { + "type": "boolean", + "description": "Flag to enable or disable quotes around 'debuggerPath'", + "default": true + }, "pipeEnv": { "type": "object", "additionalProperties": { From d08620ad8347c7ca434906ff3ecdaa1e7db3fad7 Mon Sep 17 00:00:00 2001 From: Andrew Wang Date: Tue, 14 Mar 2017 11:29:55 -0700 Subject: [PATCH 3/4] Updating Description for QuoteArgs --- package.json | 16 ++++++++-------- src/tools/OptionsSchema.json | 4 ++-- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/package.json b/package.json index 90bd062911..5ce46c25c7 100644 --- a/package.json +++ b/package.json @@ -729,7 +729,7 @@ }, "quoteArgs": { "type": "boolean", - "description": "Flag to enable or disable quotes around 'debuggerPath'", + "description": "Should arguments that contain characters that need to be quoted (example: spaces) be quoted? Defaults to 'true'. If set, the debugger command will no longer be automatically quoted.", "default": true }, "windows": { @@ -761,7 +761,7 @@ }, "quoteArgs": { "type": "boolean", - "description": "Flag to enable or disable quotes around 'debuggerPath'", + "description": "Should arguments that contain characters that need to be quoted (example: spaces) be quoted? Defaults to 'true'. If set, the debugger command will no longer be automatically quoted.", "default": true }, "pipeEnv": { @@ -803,7 +803,7 @@ }, "quoteArgs": { "type": "boolean", - "description": "Flag to enable or disable quotes around 'debuggerPath'", + "description": "Should arguments that contain characters that need to be quoted (example: spaces) be quoted? Defaults to 'true'. If set, the debugger command will no longer be automatically quoted.", "default": true }, "pipeEnv": { @@ -845,7 +845,7 @@ }, "quoteArgs": { "type": "boolean", - "description": "Flag to enable or disable quotes around 'debuggerPath'", + "description": "Should arguments that contain characters that need to be quoted (example: spaces) be quoted? Defaults to 'true'. If set, the debugger command will no longer be automatically quoted.", "default": true }, "pipeEnv": { @@ -997,7 +997,7 @@ }, "quoteArgs": { "type": "boolean", - "description": "Flag to enable or disable quotes around 'debuggerPath'", + "description": "Should arguments that contain characters that need to be quoted (example: spaces) be quoted? Defaults to 'true'. If set, the debugger command will no longer be automatically quoted.", "default": true }, "windows": { @@ -1029,7 +1029,7 @@ }, "quoteArgs": { "type": "boolean", - "description": "Flag to enable or disable quotes around 'debuggerPath'", + "description": "Should arguments that contain characters that need to be quoted (example: spaces) be quoted? Defaults to 'true'. If set, the debugger command will no longer be automatically quoted.", "default": true }, "pipeEnv": { @@ -1071,7 +1071,7 @@ }, "quoteArgs": { "type": "boolean", - "description": "Flag to enable or disable quotes around 'debuggerPath'", + "description": "Should arguments that contain characters that need to be quoted (example: spaces) be quoted? Defaults to 'true'. If set, the debugger command will no longer be automatically quoted.", "default": true }, "pipeEnv": { @@ -1113,7 +1113,7 @@ }, "quoteArgs": { "type": "boolean", - "description": "Flag to enable or disable quotes around 'debuggerPath'", + "description": "Should arguments that contain characters that need to be quoted (example: spaces) be quoted? Defaults to 'true'. If set, the debugger command will no longer be automatically quoted.", "default": true }, "pipeEnv": { diff --git a/src/tools/OptionsSchema.json b/src/tools/OptionsSchema.json index 82d0d0aea2..925823e1bb 100644 --- a/src/tools/OptionsSchema.json +++ b/src/tools/OptionsSchema.json @@ -34,7 +34,7 @@ }, "quoteArgs": { "type": "boolean", - "description": "Flag to enable or disable quotes around 'debuggerPath'", + "description": "Should arguments that contain characters that need to be quoted (example: spaces) be quoted? Defaults to 'true'. If set, the debugger command will no longer be automatically quoted.", "default": true }, "pipeEnv": { @@ -91,7 +91,7 @@ }, "quoteArgs": { "type": "boolean", - "description": "Flag to enable or disable quotes around 'debuggerPath'", + "description": "Should arguments that contain characters that need to be quoted (example: spaces) be quoted? Defaults to 'true'. If set, the debugger command will no longer be automatically quoted.", "default": true }, "windows": { From 309c515b8ac64c0ff5475fa9b075a1d1eafd8ad8 Mon Sep 17 00:00:00 2001 From: Andrew Wang Date: Tue, 14 Mar 2017 11:36:59 -0700 Subject: [PATCH 4/4] Fixing typo in description --- package.json | 16 ++++++++-------- src/tools/OptionsSchema.json | 4 ++-- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/package.json b/package.json index 5ce46c25c7..753e31ea82 100644 --- a/package.json +++ b/package.json @@ -729,7 +729,7 @@ }, "quoteArgs": { "type": "boolean", - "description": "Should arguments that contain characters that need to be quoted (example: spaces) be quoted? Defaults to 'true'. If set, the debugger command will no longer be automatically quoted.", + "description": "Should arguments that contain characters that need to be quoted (example: spaces) be quoted? Defaults to 'true'. If set to false, the debugger command will no longer be automatically quoted.", "default": true }, "windows": { @@ -761,7 +761,7 @@ }, "quoteArgs": { "type": "boolean", - "description": "Should arguments that contain characters that need to be quoted (example: spaces) be quoted? Defaults to 'true'. If set, the debugger command will no longer be automatically quoted.", + "description": "Should arguments that contain characters that need to be quoted (example: spaces) be quoted? Defaults to 'true'. If set to false, the debugger command will no longer be automatically quoted.", "default": true }, "pipeEnv": { @@ -803,7 +803,7 @@ }, "quoteArgs": { "type": "boolean", - "description": "Should arguments that contain characters that need to be quoted (example: spaces) be quoted? Defaults to 'true'. If set, the debugger command will no longer be automatically quoted.", + "description": "Should arguments that contain characters that need to be quoted (example: spaces) be quoted? Defaults to 'true'. If set to false, the debugger command will no longer be automatically quoted.", "default": true }, "pipeEnv": { @@ -845,7 +845,7 @@ }, "quoteArgs": { "type": "boolean", - "description": "Should arguments that contain characters that need to be quoted (example: spaces) be quoted? Defaults to 'true'. If set, the debugger command will no longer be automatically quoted.", + "description": "Should arguments that contain characters that need to be quoted (example: spaces) be quoted? Defaults to 'true'. If set to false, the debugger command will no longer be automatically quoted.", "default": true }, "pipeEnv": { @@ -997,7 +997,7 @@ }, "quoteArgs": { "type": "boolean", - "description": "Should arguments that contain characters that need to be quoted (example: spaces) be quoted? Defaults to 'true'. If set, the debugger command will no longer be automatically quoted.", + "description": "Should arguments that contain characters that need to be quoted (example: spaces) be quoted? Defaults to 'true'. If set to false, the debugger command will no longer be automatically quoted.", "default": true }, "windows": { @@ -1029,7 +1029,7 @@ }, "quoteArgs": { "type": "boolean", - "description": "Should arguments that contain characters that need to be quoted (example: spaces) be quoted? Defaults to 'true'. If set, the debugger command will no longer be automatically quoted.", + "description": "Should arguments that contain characters that need to be quoted (example: spaces) be quoted? Defaults to 'true'. If set to false, the debugger command will no longer be automatically quoted.", "default": true }, "pipeEnv": { @@ -1071,7 +1071,7 @@ }, "quoteArgs": { "type": "boolean", - "description": "Should arguments that contain characters that need to be quoted (example: spaces) be quoted? Defaults to 'true'. If set, the debugger command will no longer be automatically quoted.", + "description": "Should arguments that contain characters that need to be quoted (example: spaces) be quoted? Defaults to 'true'. If set to false, the debugger command will no longer be automatically quoted.", "default": true }, "pipeEnv": { @@ -1113,7 +1113,7 @@ }, "quoteArgs": { "type": "boolean", - "description": "Should arguments that contain characters that need to be quoted (example: spaces) be quoted? Defaults to 'true'. If set, the debugger command will no longer be automatically quoted.", + "description": "Should arguments that contain characters that need to be quoted (example: spaces) be quoted? Defaults to 'true'. If set to false, the debugger command will no longer be automatically quoted.", "default": true }, "pipeEnv": { diff --git a/src/tools/OptionsSchema.json b/src/tools/OptionsSchema.json index 925823e1bb..ea916a757a 100644 --- a/src/tools/OptionsSchema.json +++ b/src/tools/OptionsSchema.json @@ -34,7 +34,7 @@ }, "quoteArgs": { "type": "boolean", - "description": "Should arguments that contain characters that need to be quoted (example: spaces) be quoted? Defaults to 'true'. If set, the debugger command will no longer be automatically quoted.", + "description": "Should arguments that contain characters that need to be quoted (example: spaces) be quoted? Defaults to 'true'. If set to false, the debugger command will no longer be automatically quoted.", "default": true }, "pipeEnv": { @@ -91,7 +91,7 @@ }, "quoteArgs": { "type": "boolean", - "description": "Should arguments that contain characters that need to be quoted (example: spaces) be quoted? Defaults to 'true'. If set, the debugger command will no longer be automatically quoted.", + "description": "Should arguments that contain characters that need to be quoted (example: spaces) be quoted? Defaults to 'true'. If set to false, the debugger command will no longer be automatically quoted.", "default": true }, "windows": {