Added HttpMessageHandler but ports are still in TIME_WAIT

[datacruze]

Following this dotnet/wcf#3230 I've managed to inject my own HttpMessageHandler from IHttpMessageHandlerFactory into the WCF client.

My EndpointBehavior looks like this:

        public class CustomEndpointBehavior : IEndpointBehavior
        {
            private readonly Func<HttpMessageHandler> _httpHandler;

            public CustomEndpointBehavior(IHttpMessageHandlerFactory factory) => _httpHandler = () => factory.CreateHandler("ClientName");

            public void AddBindingParameters(ServiceEndpoint endpoint, BindingParameterCollection bindingParameters) => bindingParameters.Add(new Func<HttpClientHandler, HttpMessageHandler>(handler => _httpHandler()));

            public void ApplyClientBehavior(ServiceEndpoint endpoint, ClientRuntime clientRuntime) { }

            public void ApplyDispatchBehavior(ServiceEndpoint endpoint, EndpointDispatcher endpointDispatcher) { }

            public void Validate(ServiceEndpoint endpoint) { }
        }

In Startup.cs
services.AddHttpClient("ClientName");

And this is how I use the httpHandler:

            WcfResponseDto response;
            var binding = CreateHttpBinding();  //Basic HTTP Binding
            binding.Security.Message.ClientCredentialType = BasicHttpMessageCredentialType.Certificate;

            var factory = new ChannelFactory<MyWcfChannel>(binding, new EndpointAddress(url));
            IHttpMessageHandlerFactory httpMessageHandler = _serviceProvider.GetService(typeof(IHttpMessageHandlerFactory)) as 
            IHttpMessageHandlerFactory;
              factory.Endpoint.EndpointBehaviors.Add(new CustomEndpointBehavior(httpMessageHandler));
            factory.Credentials.ClientCertificate.Certificate = GetCertificate();  //returns a x509 certificate
           var serviceProxy = factory.CreateChannel();

            try
            {

                ((ICommunicationObject)serviceProxy).Open();
                response = await
                    serviceProxy.EnterpriseGetCountyDetailsAsync(requestDto).ConfigureAwait(false);
            }
            catch (Exception ex)
            {
                ((ICommunicationObject)serviceProxy).Abort();
                factory.Abort();
                throw new FaultException(ex.Message);
            }
            finally
            {
                ((ICommunicationObject)serviceProxy).Close();
                factory.Close();
            }

            return response;
        }

When I use SOAP UI load test, I still see the ports open in TIME_WAIT after the application is done executing the load test. Is the HttpMessagehandler not working as it should or am I implementing it wrong? I am using the latest System.ServiceModel* dll (4.9.0)

[datacruze]

Hi, @mconnew any insights please?

[dotnet-issue-labeler]

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[HongGit]

Transfer to runtime, this is a question of behavior of IHttpMessageHandlerFactory.

[ghost]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Following this dotnet/wcf#3230 I've managed to inject my own HttpMessageHandler from IHttpMessageHandlerFactory into the WCF client.

My EndpointBehavior looks like this:
`public class CustomEndpointBehavior : IEndpointBehavior
{
private readonly Func _httpHandler;

        public CustomEndpointBehavior(IHttpMessageHandlerFactory factory) => _httpHandler = () => factory.CreateHandler("ClientName");

        public void AddBindingParameters(ServiceEndpoint endpoint, BindingParameterCollection bindingParameters) => bindingParameters.Add(new Func<HttpClientHandler, HttpMessageHandler>(handler => _httpHandler()));

        public void ApplyClientBehavior(ServiceEndpoint endpoint, ClientRuntime clientRuntime) { }

        public void ApplyDispatchBehavior(ServiceEndpoint endpoint, EndpointDispatcher endpointDispatcher) { }

        public void Validate(ServiceEndpoint endpoint) { }
    }`

In Startup.cs
services.AddHttpClient("ClientName");

And this is how I use the httpHandler:
`
WcfResponseDto response;
var binding = CreateHttpBinding(); //Basic HTTP Binding
binding.Security.Message.ClientCredentialType = BasicHttpMessageCredentialType.Certificate;

        var factory = new ChannelFactory<MyWcfChannel>(binding, new EndpointAddress(url));
        IHttpMessageHandlerFactory httpMessageHandler = _serviceProvider.GetService(typeof(IHttpMessageHandlerFactory)) as 
        IHttpMessageHandlerFactory;
          factory.Endpoint.EndpointBehaviors.Add(new CustomEndpointBehavior(httpMessageHandler));
        factory.Credentials.ClientCertificate.Certificate = GetCertificate();  //returns a x509 certificate
       var serviceProxy = factory.CreateChannel();

        try
        {

            ((ICommunicationObject)serviceProxy).Open();
            response = await
                serviceProxy.EnterpriseGetCountyDetailsAsync(requestDto).ConfigureAwait(false);
        }
        catch (Exception ex)
        {
            ((ICommunicationObject)serviceProxy).Abort();
            factory.Abort();
            throw new FaultException(ex.Message);
        }
        finally
        {
            ((ICommunicationObject)serviceProxy).Close();
            factory.Close();
        }

        return response;
    }

`

When I use SOAP UI load test, I still see the ports open in TIME_WAIT after the application is done executing the load test. Is the HttpMessagehandler not working as it should or am I implementing it wrong? I am using the latest System.ServiceModel* dll (4.9.0)

Author:	datacruze
Assignees:	-
Labels:	area-System.Net.Http, untriaged
Milestone:	-

[wfurt]

That will go away: https://docs.microsoft.com/en-us/answers/questions/230227/time-wait-from-netstat.html

[ghost]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Following this dotnet/wcf#3230 I've managed to inject my own HttpMessageHandler from IHttpMessageHandlerFactory into the WCF client.

My EndpointBehavior looks like this:

        public class CustomEndpointBehavior : IEndpointBehavior
        {
            private readonly Func<HttpMessageHandler> _httpHandler;

            public CustomEndpointBehavior(IHttpMessageHandlerFactory factory) => _httpHandler = () => factory.CreateHandler("ClientName");

            public void AddBindingParameters(ServiceEndpoint endpoint, BindingParameterCollection bindingParameters) => bindingParameters.Add(new Func<HttpClientHandler, HttpMessageHandler>(handler => _httpHandler()));

            public void ApplyClientBehavior(ServiceEndpoint endpoint, ClientRuntime clientRuntime) { }

            public void ApplyDispatchBehavior(ServiceEndpoint endpoint, EndpointDispatcher endpointDispatcher) { }

            public void Validate(ServiceEndpoint endpoint) { }
        }

In Startup.cs
services.AddHttpClient("ClientName");

And this is how I use the httpHandler:

            WcfResponseDto response;
            var binding = CreateHttpBinding();  //Basic HTTP Binding
            binding.Security.Message.ClientCredentialType = BasicHttpMessageCredentialType.Certificate;

            var factory = new ChannelFactory<MyWcfChannel>(binding, new EndpointAddress(url));
            IHttpMessageHandlerFactory httpMessageHandler = _serviceProvider.GetService(typeof(IHttpMessageHandlerFactory)) as 
            IHttpMessageHandlerFactory;
              factory.Endpoint.EndpointBehaviors.Add(new CustomEndpointBehavior(httpMessageHandler));
            factory.Credentials.ClientCertificate.Certificate = GetCertificate();  //returns a x509 certificate
           var serviceProxy = factory.CreateChannel();

            try
            {

                ((ICommunicationObject)serviceProxy).Open();
                response = await
                    serviceProxy.EnterpriseGetCountyDetailsAsync(requestDto).ConfigureAwait(false);
            }
            catch (Exception ex)
            {
                ((ICommunicationObject)serviceProxy).Abort();
                factory.Abort();
                throw new FaultException(ex.Message);
            }
            finally
            {
                ((ICommunicationObject)serviceProxy).Close();
                factory.Close();
            }

            return response;
        }

When I use SOAP UI load test, I still see the ports open in TIME_WAIT after the application is done executing the load test. Is the HttpMessagehandler not working as it should or am I implementing it wrong? I am using the latest System.ServiceModel* dll (4.9.0)

Author:	datacruze
Assignees:	-
Labels:	untriaged, area-Extensions-HttpClientFactory
Milestone:	-

[karelz]

Triage: This is by design behavior of the OS when we close Socket. As @wfurt mentions above, it will disappear.
If you are trying to limit the max number of connections, you can use MaxConnectionsPerServer to limit that.
Closing as resolved. Let us know if we misunderstood what you need.