Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageCollection_IListItem_SetWithHandle_GetReturnsExpected appears to be flakey #2686

Open
hughbe opened this issue Jan 11, 2020 · 3 comments
Open

Comments

@hughbe
Copy link
Contributor

@hughbe hughbe commented Jan 11, 2020

https://dev.azure.com/dnceng/public/_test/analytics?definitionId=267&contextType=build

https://dev.azure.com/dnceng/public/_build/results?buildId=479537&view=ms.vss-test-web.build-test-results-tab

System.InvalidOperationException : Image cannot be added to the ImageList.
at System.Windows.Forms.ImageList.AddToHandle(Bitmap bitmap) in //src/System.Windows.Forms/src/System/Windows/Forms/ImageList.cs:line 548
at System.Windows.Forms.ImageList.CreateHandle() in /
/src/System.Windows.Forms/src/System/Windows/Forms/ImageList.cs:line 617
at System.Windows.Forms.ImageList.get_Handle() in //src/System.Windows.Forms/src/System/Windows/Forms/ImageList.cs:line 218
at System.Windows.Forms.Tests.ImageCollectionTests.ImageCollection_IListItem_SetWithHandle_GetReturnsExpected(Color transparentColor, Image value) in /
/src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ImageList.ImageCollectionTests.cs:line 1645

@weltkante

This comment has been minimized.

Copy link
Contributor

@weltkante weltkante commented Jan 11, 2020

First link says Control_OnPaintBackground_InvokeWithParent_CallsPaint failed never mind I was able to scroll down for more failures

Second link says ImageCollection_IListItem_SetWithHandle_GetReturnsExpected failed and line 1645 in ImageCollectionTests.cs is the latter, so stack trace probably belongs to that.

Neither stacktrace nor second link is about ImageCollection_Add_InvokeIconWithHandle_Success so if you did some investigation you may want to add some more details?

@hughbe hughbe changed the title ImageCollection_Add_InvokeIconWithHandle_Success appears to be flakey ImageCollection_IListItem_SetWithHandle_GetReturnsExpected appears to be flakey Jan 11, 2020
@hughbe

This comment has been minimized.

Copy link
Contributor Author

@hughbe hughbe commented Jan 11, 2020

Sorry, updated the title: this issue relates to ImageCollection_IListItem_SetWithHandle_GetReturnsExpected

Control_OnPaintBackground_InvokeWithParent_CallsPaint and associated failures have been fixed because we had timing bug in Application.EnableVisualStyles calls in the tests

@RussKie

This comment has been minimized.

Copy link
Member

@RussKie RussKie commented Jan 13, 2020

All tests appear green now... ¯\_(ツ)_/¯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.