New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add appcompat for shared assembly System.Drawing between winforms and corefx and also between winforms and Desktop. #407

Open
dreddy-work opened this Issue Feb 1, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@dreddy-work
Copy link
Member

dreddy-work commented Feb 1, 2019

System.Drawing.dll exists in corefx and winforms. Winforms assembly is expected to be a super-set of corefx version and should win at load time in all applicable scenarios. To make sure of this, We made file version of this assembly in winforms higher than the corefx version. We also need to add appcompat in the build process to make sure we never go out of sync of these assumptions.

@dreddy-work dreddy-work self-assigned this Feb 1, 2019

@merriemcgaw merriemcgaw added this to the 3.0 milestone Feb 8, 2019

@zsd4yr

This comment has been minimized.

Copy link
Member

zsd4yr commented Feb 14, 2019

@dreddy-work isn't this in?

@zsd4yr

This comment has been minimized.

Copy link
Member

zsd4yr commented Feb 15, 2019

Need to regenerate our facade in the case the Core FX adds types. This test in the build will ensure this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment