New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove explicit "\r\n" test from the .resx files in this repo because these strings will be escaped by the resx reader and will not be displayed as new lines #429

Open
Tanya-Solyanik opened this Issue Feb 12, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@Tanya-Solyanik
Copy link
Member

Tanya-Solyanik commented Feb 12, 2019

  • .NET Core 3.0 Preview1
  • Have you experienced this same bug with .NET Framework?: No - resources are in a different format there

Sample repro:
run this code:
(new ThreadExceptionDialog(new Exception("Really long exception description string, because we want to see if it properly wraps around or is truncated."))).Show();

Actual:
image

Expected - "\r\n" text is displayed as a new line

Tanya-Solyanik added a commit that referenced this issue Feb 12, 2019

* replaced hardcoded text that represents a resource name with a get …
…property that reads this resource

* replaced explicit \r\n strings in SR.RESX file for system.windows.forms.dll with newlines because resx reader escapes them and as a result we don't have new lines in the displayed text
* for other assemblies in this repo, I created a tracking issue to fix resx files:
#429

Tanya-Solyanik added a commit that referenced this issue Feb 12, 2019

* replaced hardcoded text that represents a resource name with a get …
…property that reads this resource

* replaced explicit \r\n strings in SR.RESX file for system.windows.forms.dll with newlines because resx reader escapes them and as a result we don't have new lines in the displayed text
* for other assemblies in this repo, I created a tracking issue to fix resx files:
#429

Tanya-Solyanik added a commit that referenced this issue Feb 12, 2019

* replaced hardcoded text that represents a resource name with a get …
…property that reads this resource

* replaced explicit \r\n strings in SR.RESX file for system.windows.forms.dll with newlines because resx reader escapes them and as a result we don't have new lines in the displayed text
* for other assemblies in this repo, I created a tracking issue to fix resx files:
#429

Tanya-Solyanik added a commit that referenced this issue Feb 13, 2019

Fix text in the ThreadExceptionDialog (#430)
Fixes #202 
* replaced hardcoded text that represents a resource name with a get …property that reads this resource
* replaced explicit \r\n strings in SR.RESX file for system.windows.forms.dll with newlines because resx reader escapes them and as a result we don't have new lines in the displayed text
* for other assemblies in this repo, I created a tracking issue to fix SR.resx files:
#429
* added a test for this dialog to `WinformsControlsTest`, @zsd4yr  - please review, I tested this change by running the app, is there anything else to run

Before:
![image](https://user-images.githubusercontent.com/15823268/52612877-6e9bce00-2e40-11e9-80a2-41efcf9b94ca.png)

After:
![image](https://user-images.githubusercontent.com/15823268/52612888-765b7280-2e40-11e9-988f-9501c75af58f.png)

@zsd4yr zsd4yr added this to the 3.0 milestone Feb 15, 2019

@zsd4yr

This comment has been minimized.

Copy link
Member

zsd4yr commented Feb 15, 2019

  • System.Windows.Forms
  • System.Windows.Forms.Editors
  • System.Windows.Forms.Editors.Design
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment