New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unwanted comments from System.Windows.Forms code #50

Closed
Shyam-Gupta opened this Issue Nov 15, 2018 · 2 comments

Comments

Projects
None yet
4 participants
@Shyam-Gupta
Member

Shyam-Gupta commented Nov 15, 2018

Feedback from @danmosemsft:

Remove comments like:
///
/// [To be supplied.]
///

from ResXResourceWriter.cs and other files.

@garfbradaz

This comment has been minimized.

garfbradaz commented Dec 5, 2018

A little unrelated but can Winforms repository make use of the same Dead Code analysis as CoreFX?

dotnet/corefx#17905

cc @ericstj

@merriemcgaw merriemcgaw added this to the Future milestone Dec 6, 2018

@ericstj

This comment has been minimized.

Member

ericstj commented Dec 6, 2018

I agree the dead code analysis would be good to get going on some of these new repositories. It's another good testcase for the ILLinker (WPF especially, since it relies on internals and reflection heavily).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment