Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move refout project settings to a targets file #583

Open
Shyam-Gupta opened this Issue Mar 13, 2019 · 0 comments

Comments

Projects
None yet
3 participants
@Shyam-Gupta
Copy link
Member

Shyam-Gupta commented Mar 13, 2019

As part of PR #237, we have added following two properties in each implementation assembly:

<Deterministic>true</Deterministic>
<ProduceReferenceAssembly>true</ProduceReferenceAssembly>

As per Eric's feedback, we should move them to Directory.Build.props under a conditional section like:

It means we will need to add IsShipping property in implementation assemblies.

But problem is that due to order of evaluation of props files, project properties are not available at that point.

Hence we need to move these to a targets file.

@zsd4yr zsd4yr added this to the 3.0 milestone Mar 15, 2019

@zsd4yr zsd4yr modified the milestones: 3.0, Future Mar 15, 2019

@zsd4yr zsd4yr added the easy label Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.