diff --git a/src/System.Windows.Forms/src/PublicAPI.Unshipped.txt b/src/System.Windows.Forms/src/PublicAPI.Unshipped.txt index 102d835a48a..2812b119802 100644 --- a/src/System.Windows.Forms/src/PublicAPI.Unshipped.txt +++ b/src/System.Windows.Forms/src/PublicAPI.Unshipped.txt @@ -13,6 +13,8 @@ *REMOVED*virtual System.Windows.Forms.Control.ControlCollection.AddRange(System.Windows.Forms.Control![]! controls) -> void *REMOVED*virtual System.Windows.Forms.ListView.ColumnHeaderCollection.AddRange(System.Windows.Forms.ColumnHeader![]! values) -> void *REMOVED*virtual System.Windows.Forms.TreeNodeCollection.AddRange(System.Windows.Forms.TreeNode![]! nodes) -> void +*REMOVED*override System.Windows.Forms.DataGridViewTextBoxEditingControl.OnHandleCreated(System.EventArgs! e) -> void +*REMOVED*override System.Windows.Forms.DataGridViewComboBoxEditingControl.OnHandleCreated(System.EventArgs! e) -> void System.Windows.Forms.AutoCompleteStringCollection.AddRange(params string![]! value) -> void System.Windows.Forms.ComboBox.ObjectCollection.AddRange(params object![]! items) -> void System.Windows.Forms.ImageList.ImageCollection.AddRange(params System.Drawing.Image![]! images) -> void diff --git a/src/System.Windows.Forms/src/System/Windows/Forms/Controls/DataGridView/DataGridViewComboBoxEditingControl.cs b/src/System.Windows.Forms/src/System/Windows/Forms/Controls/DataGridView/DataGridViewComboBoxEditingControl.cs index 4be65a2b4dc..6905fff6e7b 100644 --- a/src/System.Windows.Forms/src/System/Windows/Forms/Controls/DataGridView/DataGridViewComboBoxEditingControl.cs +++ b/src/System.Windows.Forms/src/System/Windows/Forms/Controls/DataGridView/DataGridViewComboBoxEditingControl.cs @@ -17,10 +17,12 @@ public DataGridViewComboBoxEditingControl() : base() TabStop = false; } - protected override AccessibleObject CreateAccessibilityInstance() => - new DataGridViewComboBoxEditingControlAccessibleObject(this); - - // IDataGridViewEditingControl interface implementation + protected override AccessibleObject CreateAccessibilityInstance() + { + var controlAccessibleObject = new DataGridViewComboBoxEditingControlAccessibleObject(this); + _dataGridView?.SetAccessibleObjectParent(controlAccessibleObject); + return controlAccessibleObject; + } public virtual DataGridView? EditingControlDataGridView { @@ -124,17 +126,6 @@ protected override void OnSelectedIndexChanged(EventArgs e) } } - protected override void OnHandleCreated(EventArgs e) - { - base.OnHandleCreated(e); - - // The null-check was added as a fix for a https://github.com/dotnet/winforms/issues/2138 - if (_dataGridView?.IsAccessibilityObjectCreated == true) - { - _dataGridView.SetAccessibleObjectParent(AccessibilityObject); - } - } - internal override void ReleaseUiaProvider(HWND handle) { if (TryGetAccessibilityObject(out AccessibleObject? accessibleObject)) diff --git a/src/System.Windows.Forms/src/System/Windows/Forms/Controls/DataGridView/DataGridViewTextBoxEditingControl.cs b/src/System.Windows.Forms/src/System/Windows/Forms/Controls/DataGridView/DataGridViewTextBoxEditingControl.cs index e8ff9c27c80..6954ff74eb4 100644 --- a/src/System.Windows.Forms/src/System/Windows/Forms/Controls/DataGridView/DataGridViewTextBoxEditingControl.cs +++ b/src/System.Windows.Forms/src/System/Windows/Forms/Controls/DataGridView/DataGridViewTextBoxEditingControl.cs @@ -22,7 +22,11 @@ public DataGridViewTextBoxEditingControl() : base() } protected override AccessibleObject CreateAccessibilityInstance() - => new DataGridViewTextBoxEditingControlAccessibleObject(this); + { + var controlAccessibleObject = new DataGridViewTextBoxEditingControlAccessibleObject(this); + _dataGridView?.SetAccessibleObjectParent(controlAccessibleObject); + return controlAccessibleObject; + } public virtual DataGridView? EditingControlDataGridView { @@ -309,15 +313,4 @@ private static HorizontalAlignment TranslateAlignment(DataGridViewContentAlignme return HorizontalAlignment.Left; } } - - protected override void OnHandleCreated(EventArgs e) - { - base.OnHandleCreated(e); - - // The null-check was added as a fix for a https://github.com/dotnet/winforms/issues/2138 - if (IsHandleCreated && _dataGridView?.IsAccessibilityObjectCreated == true) - { - _dataGridView.SetAccessibleObjectParent(AccessibilityObject); - } - } }