New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an Sdk section to global.json #176

Merged
merged 1 commit into from Dec 6, 2018

Conversation

Projects
None yet
3 participants
@vatsan-madhavan
Member

vatsan-madhavan commented Dec 6, 2018

Adding an Sdk section to global.json. This is needed to ensure that CI servers deterministically use the version of .NET Core 3.0 Sdk specified here to build the projects in the repo.

Vatsan Madhavan
Adding an Sdk section to global.json. This is needed to ensure that C…
…I servers deterministically use the version of .NET Core 3.0 Sdk specified here to build the projects in the repo.

@vatsan-madhavan vatsan-madhavan requested a review from dotnet/dotnet-winforms as a code owner Dec 6, 2018

@vatsan-madhavan vatsan-madhavan requested review from alexperovich and riarenas Dec 6, 2018

@zsd4yr

This comment has been minimized.

Member

zsd4yr commented Dec 6, 2018

@vatsan-madhavan JSON noob question: Is there no way to define a variable in JSON? Having this version hard-asserted twice is not ideal.

@zsd4yr zsd4yr self-requested a review Dec 6, 2018

@zsd4yr

This comment has been minimized.

Member

zsd4yr commented Dec 6, 2018

Is there no way to do something like this?

{
  "SDKver": "3.0.100-preview-009784"
  "tools": {
    "dotnet": `$(SDKver)`
  },
  "sdk": {
    "version": `$(SDKver)`
  },
  "msbuild-sdks": {
    "Microsoft.DotNet.Arcade.Sdk": "1.0.0-beta.18605.3"
  }
}

@alexperovich

This comment has been minimized.

Member

alexperovich commented Dec 6, 2018

Unfortunately not. The json spec doesn't have anything like that and the tools that read that file don't have anything that can resolve references like that.

@zsd4yr

This comment has been minimized.

Member

zsd4yr commented Dec 6, 2018

Unfortunately not. The json spec doesn't have anything like that and the tools that read that file don't have anything that can resolve references like that.

😭 okay

@zsd4yr

zsd4yr approved these changes Dec 6, 2018

@zsd4yr zsd4yr merged commit 9d03dbf into master Dec 6, 2018

1 check passed

license/cla All CLA requirements met.

@vatsan-madhavan vatsan-madhavan deleted the sdk-version branch Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment