Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IHandle and HandleRef overloads to GetWindow #2291

Merged
merged 1 commit into from Nov 12, 2019

Conversation

@gpetrou
Copy link
Contributor

gpetrou commented Nov 5, 2019

Proposed changes

  • Add IHandle/HandleRef overloads to GetWindow.
  • Based on similar feedback on #2277
Microsoft Reviewers: Open in CodeFlow
@gpetrou gpetrou requested a review from dotnet/dotnet-winforms as a code owner Nov 5, 2019
@RussKie

This comment has been minimized.

Copy link
Member

RussKie commented Nov 7, 2019

The build is failing

@gpetrou gpetrou force-pushed the gpetrou:GetWindow branch from d55094c to fb60cbf Nov 12, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 12, 2019

Codecov Report

Merging #2291 into master will decrease coverage by 0.00747%.
The diff coverage is 42.85714%.

@@                 Coverage Diff                 @@
##              master       #2291         +/-   ##
===================================================
- Coverage   29.57052%   29.56304%   -0.00748%     
===================================================
  Files            950         951          +1     
  Lines         266556      266566         +10     
  Branches       37940       37940                 
===================================================
- Hits           78822       78805         -17     
- Misses        182558      182587         +29     
+ Partials        5176        5174          -2
Flag Coverage Δ
#Debug 29.56304% <42.85714%> (-0.00748%) ⬇️
#production 29.56304% <42.85714%> (-0.00748%) ⬇️
#test 100% <ø> (?)
@gpetrou gpetrou force-pushed the gpetrou:GetWindow branch from fb60cbf to 782936b Nov 12, 2019
@gpetrou

This comment has been minimized.

Copy link
Contributor Author

gpetrou commented Nov 12, 2019

@RussKie this is ready now.

@RussKie RussKie added the enhancement label Nov 12, 2019
@RussKie RussKie merged commit 37b52ea into dotnet:master Nov 12, 2019
5 checks passed
5 checks passed
WIP Ready for review
Details
dotnet-winforms CI Build #20191111.41 had test failures
Details
dotnet-winforms CI (Build Windows Debug) Build Windows Debug succeeded
Details
dotnet-winforms CI (Build Windows Release) Build Windows Release succeeded
Details
license/cla All CLA requirements met.
Details
@msftbot msftbot bot added this to the 5.0 milestone Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.