Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SYSTEMTIMEARRAY #2294

Open
wants to merge 1 commit into
base: master
from

Conversation

@hughbe
Copy link
Contributor

hughbe commented Nov 6, 2019

Proposed Changes

  • Use Span
Microsoft Reviewers: Open in CodeFlow
@hughbe hughbe requested a review from dotnet/dotnet-winforms as a code owner Nov 6, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #2294 into master will increase coverage by 0.17182%.
The diff coverage is 66.66667%.

@@                Coverage Diff                 @@
##              master      #2294         +/-   ##
==================================================
+ Coverage   28.03227%   28.2041%   +0.17183%     
==================================================
  Files            991        991                 
  Lines         259055     259012         -43     
  Branches       36814      36814                 
==================================================
+ Hits           72619      73052        +433     
+ Misses        181609     181102        -507     
- Partials        4827       4858         +31
Flag Coverage Δ
#Debug 28.2041% <66.66667%> (+0.17182%) ⬆️
#production 28.2041% <66.66667%> (+0.17182%) ⬆️
#test ?
@RussKie

This comment has been minimized.

Copy link
Member

RussKie commented Nov 11, 2019

@msftbot merge if @JeremyKuhne approves

@msftbot msftbot bot added the :octocat: automerge label Nov 11, 2019
@msftbot

This comment was marked as resolved.

Copy link
Contributor

msftbot bot commented Nov 11, 2019

Hello @RussKie!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I'll only merge this pull request if it's approved by @JeremyKuhne

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@RussKie RussKie requested a review from JeremyKuhne Nov 11, 2019
@RussKie RussKie added the enhancement label Nov 11, 2019
@RussKie RussKie assigned hughbe and JeremyKuhne and unassigned hughbe Nov 13, 2019
@RussKie

This comment has been minimized.

Copy link
Member

RussKie commented Nov 13, 2019

MC

@RussKie RussKie removed the :octocat: automerge label Nov 13, 2019
@RussKie

This comment was marked as resolved.

Copy link
Member

RussKie commented Nov 13, 2019

@msftbot nevermind

@hughbe hughbe force-pushed the hughbe:SYSTEMTIMEARRAY branch from 022e731 to a007942 Nov 13, 2019
@hughbe hughbe force-pushed the hughbe:SYSTEMTIMEARRAY branch from a007942 to 1b0c79b Nov 13, 2019
@RussKie

This comment has been minimized.

Copy link
Member

RussKie commented Nov 14, 2019

@JeremyKuhne could you please have a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.