Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port MaskedTextBoxTextEditor and MaskPropertyEditor #2297

Merged

Conversation

@M-Lipin
Copy link
Member

M-Lipin commented Nov 6, 2019

Fixes #2285
Fixes #2286

Proposed changes

  • Adding MaskTextBoxTextEditor, MaskPropertyEditor and related entitity definitions to System.Windows.Forms.Design project.
  • Adding required resources.
  • Updating System.Design façade to allow using ported editors.

Customer Impact

  • Users will be able to use MaskTextBoxTextEditor with MaskedTextBox control and MaskPropertyEditor with Mask property of the MaskTextBox.

Regression?

  • Yes

Risk

  • Minimal

Screenshots

Before

Only simple text edit is available.

After

image

Test methodology

  • Manual testing;
  • Unit tests (to be implemented);
  • UI automation tests.

Accessibility testing

Test environment(s)

Runtime Environment:
OS Name: Windows
OS Version: 10.0.18363
OS Platform: Windows
RID: win10-x64

.NET Core SDKs installed:
3.1.100-preview3-014642 [C:\Program Files\dotnet\sdk]

Microsoft Reviewers: Open in CodeFlow
@M-Lipin M-Lipin requested a review from dotnet/dotnet-winforms as a code owner Nov 6, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #2297 into release/3.1-uitypeeditors will decrease coverage by 0.23882%.
The diff coverage is 0%.

@@                         Coverage Diff                         @@
##           release/3.1-uitypeeditors       #2297         +/-   ##
===================================================================
- Coverage                   26.35623%   26.11741%   -0.23882%     
===================================================================
  Files                            825         836         +11     
  Lines                         270972      272305       +1333     
  Branches                       38365       38457         +92     
===================================================================
- Hits                           71418       71119        -299     
- Misses                        194475      196109       +1634     
+ Partials                        5079        5077          -2
Flag Coverage Δ
#Debug 26.11741% <0%> (-0.23883%) ⬇️
#production 26.11741% <0%> (-0.23883%) ⬇️
#test 100% <ø> (ø) ⬆️
@M-Lipin M-Lipin self-assigned this Nov 6, 2019
@M-Lipin M-Lipin force-pushed the dev/v-milipi/MaskedTextBox_UIEditors branch from 11a93bf to 6128ae9 Nov 7, 2019
@RussKie RussKie force-pushed the dev/v-milipi/MaskedTextBox_UIEditors branch from 6128ae9 to 197c381 Nov 7, 2019
@RussKie RussKie changed the title UI Type Editors: Porting MaskedTextBoxTextEditor and MaskPropertyEditor Port MaskedTextBoxTextEditor and MaskPropertyEditor Nov 7, 2019
@RussKie RussKie merged commit ff40778 into release/3.1-uitypeeditors Nov 7, 2019
5 checks passed
5 checks passed
WIP Ready for review
Details
dotnet-winforms CI Build #20191107.36 succeeded
Details
dotnet-winforms CI (Build Windows Debug) Build Windows Debug succeeded
Details
dotnet-winforms CI (Build Windows Release) Build Windows Release succeeded
Details
license/cla All CLA requirements met.
Details
@RussKie RussKie deleted the dev/v-milipi/MaskedTextBox_UIEditors branch Nov 7, 2019
RussKie added a commit that referenced this pull request Nov 8, 2019
RussKie added a commit that referenced this pull request Nov 8, 2019
RussKie added a commit that referenced this pull request Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.