Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port LinkAreaEditor #2298

Merged

Conversation

@M-Lipin
Copy link
Member

M-Lipin commented Nov 6, 2019

Fixes #2284

Proposed changes

  • Porting LinkAreaEditor;
  • Porting LinkAreaEditor resources.

Customer Impact

  • Users will be able to edit LinkArea (LinkLabel property) via LinkAreaEditor

Regression?

  • Yes

Risk

  • Minimal

Screenshots

Before

image

After

image

Test methodology

  • Manual testing;
  • Unit tests (to be implemented);
  • Automation tests.

Accessibility testing

Test environment(s)

Runtime Environment:
OS Name: Windows
OS Version: 10.0.18363
OS Platform: Windows
RID: win10-x64
.NET Core SDKs installed:
3.1.100-preview3-014642 [C:\Program Files\dotnet\sdk]

Microsoft Reviewers: Open in CodeFlow
@M-Lipin M-Lipin requested a review from dotnet/dotnet-winforms as a code owner Nov 6, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #2298 into release/3.1-uitypeeditors will decrease coverage by 0.01003%.
The diff coverage is 0%.

@@                         Coverage Diff                         @@
##           release/3.1-uitypeeditors       #2298         +/-   ##
===================================================================
- Coverage                   26.38787%   26.37784%   -0.01004%     
===================================================================
  Files                            819         820          +1     
  Lines                         269730      269878        +148     
  Branches                       38260       38270         +10     
===================================================================
+ Hits                           71176       71188         +12     
- Misses                        193477      193615        +138     
+ Partials                        5077        5075          -2
Flag Coverage Δ
#Debug 26.37784% <0%> (-0.01004%) ⬇️
#production 26.37784% <0%> (-0.01004%) ⬇️
#test 100% <ø> (ø) ⬆️
Copy link
Member

Tanya-Solyanik left a comment

Looks good.
You did not make any changes to the original code, right?
Had you done any manual testing?

@M-Lipin M-Lipin self-assigned this Nov 6, 2019
@M-Lipin

This comment has been minimized.

Copy link
Member Author

M-Lipin commented Nov 6, 2019

You did not make any changes to the original code, right?
Had you done any manual testing?

Thank you for the review @Tanya-Solyanik. Right. no changes comparing with original code. I performed manual testing - works well (no difference comparing with original LinkArea editor)

private LinkAreaEditor editor;
private IWindowsFormsEditorService edSvc;
Comment on lines 96 to 97

This comment has been minimized.

Copy link
@RussKie

RussKie Nov 7, 2019

Member

VS says these are unused
image

Can you please check if we missed something?

This comment has been minimized.

Copy link
@M-Lipin

M-Lipin Nov 7, 2019

Author Member

Thanks for the updates and cleanup!

@M-Lipin M-Lipin force-pushed the dev/v-milipi/UI_Editors_LinkAreaEditor branch from 5fd14c0 to 2fc8a17 Nov 7, 2019
M-Lipin and others added 2 commits Nov 6, 2019
@RussKie RussKie force-pushed the dev/v-milipi/UI_Editors_LinkAreaEditor branch from 2fc8a17 to e033652 Nov 7, 2019
@RussKie RussKie changed the title Porting LinkAreaEditor Port LinkAreaEditor Nov 7, 2019
@RussKie RussKie merged commit bb76bc1 into release/3.1-uitypeeditors Nov 7, 2019
5 checks passed
5 checks passed
WIP Ready for review
Details
dotnet-winforms CI Build #20191107.30 succeeded
Details
dotnet-winforms CI (Build Windows Debug) Build Windows Debug succeeded
Details
dotnet-winforms CI (Build Windows Release) Build Windows Release succeeded
Details
license/cla All CLA requirements met.
Details
@RussKie RussKie deleted the dev/v-milipi/UI_Editors_LinkAreaEditor branch Nov 7, 2019
@RussKie RussKie added this to the 3.1 milestone Nov 7, 2019
RussKie added a commit that referenced this pull request Nov 8, 2019
RussKie added a commit that referenced this pull request Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.