Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup PostMessage interop #2304

Open
wants to merge 1 commit into
base: master
from

Conversation

@hughbe
Copy link
Contributor

hughbe commented Nov 6, 2019

Microsoft Reviewers: Open in CodeFlow
@hughbe hughbe requested a review from dotnet/dotnet-winforms as a code owner Nov 6, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #2304 into master will decrease coverage by 0.0136%.
The diff coverage is 30%.

@@                Coverage Diff                 @@
##              master       #2304        +/-   ##
==================================================
- Coverage   28.03227%   28.01867%   -0.0136%     
==================================================
  Files            991         991                
  Lines         259055      259063         +8     
  Branches       36814       36814                
==================================================
- Hits           72619       72586        -33     
- Misses        181609      181643        +34     
- Partials        4827        4834         +7
Flag Coverage Δ
#Debug 28.01867% <30%> (-0.01361%) ⬇️
#production 28.01867% <30%> (-0.01361%) ⬇️
#test 100% <ø> (ø) ⬆️
@@ -18,13 +18,13 @@ internal static partial class User32
IntPtr lParam = default);

public static BOOL PostMessageW(
IHandle hWnd,

This comment has been minimized.

Copy link
@gpetrou

gpetrou Nov 8, 2019

Contributor

We have a similar situation in #2221 and waiting for some feedback.

This comment has been minimized.

Copy link
@hughbe

hughbe Nov 11, 2019

Author Contributor

Adding InternalsVisibleTo requires a lot of changes out of the scope of this PR. My suggestion: get this merged, then work on InternalsVisibleTo

  • E.g. we need to consolidate ExternDll and UnsafeNativeMethods

This comment has been minimized.

Copy link
@JeremyKuhne

JeremyKuhne Nov 12, 2019

Member

I moved IHandle to the shared code, so you can leave this.

@hughbe hughbe force-pushed the hughbe:PostMessage branch 2 times, most recently from 88ca187 to c555fb9 Nov 8, 2019
Copy link
Member

JeremyKuhne left a comment

I've moved IHandle up, so you should be able to use it now.

@hughbe hughbe force-pushed the hughbe:PostMessage branch from c555fb9 to e3c4467 Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.