Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port SelectedPathEditor #2305

Conversation

@vladimir-krestov
Copy link
Contributor

vladimir-krestov commented Nov 6, 2019

Fixes #2282
Related issue #1115

Proposed changes

  • Port SelectedPathEditor
  • Add TypeForwardedTo statement for SelectedPathEditor
  • Make code refactoring
  • Add a unit test case to check SelectedPathEditor

Customer Impact

  • Changed SelectedPath editor to compliance with .Net 4.8.

Regression?

  • Yes

Risk

  • Low

Screenshots

Before

image

After

image

image

Test methodology

  • Manual UI testing
  • CTI
  • Unit testing

Test environment(s)

  • .Net Core version: 3.1.0-preview3.19553.2
  • Microsoft Windows [Version 10.0.18362.418]
Microsoft Reviewers: Open in CodeFlow
@vladimir-krestov vladimir-krestov requested a review from dotnet/dotnet-winforms as a code owner Nov 6, 2019
@vladimir-krestov vladimir-krestov self-assigned this Nov 6, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #2305 into release/3.1-uitypeeditors will increase coverage by 0.09074%.
The diff coverage is 0%.

@@                         Coverage Diff                         @@
##           release/3.1-uitypeeditors       #2305         +/-   ##
===================================================================
+ Coverage                   26.28007%   26.37082%   +0.09075%     
===================================================================
  Files                            830         819         -11     
  Lines                         271860      269730       -2130     
  Branches                       38588       38260        -328     
===================================================================
- Hits                           71445       71130        -315     
+ Misses                        195331      193521       -1810     
+ Partials                        5084        5079          -5
Flag Coverage Δ
#Debug 26.37082% <0%> (+0.09074%) ⬆️
#production 26.37082% <0%> (+0.09074%) ⬆️
#test 100% <ø> (ø) ⬆️
@vladimir-krestov vladimir-krestov changed the title WIP: Porting SelectedPathEditor Porting SelectedPathEditor Nov 7, 2019
Fixes issue #2282
Added unit test case
Fixed incorrect FolderNameEditor.ShowDialog method
@vladimir-krestov vladimir-krestov force-pushed the dev/v-vlkres/EditorsPort/SelectedPathEditor branch from 26f6052 to 72d288c Nov 7, 2019
@vladimir-krestov

This comment has been minimized.

Copy link
Contributor Author

vladimir-krestov commented Nov 7, 2019

Testers approved these changes ✔️

@merriemcgaw

This comment has been minimized.

Copy link
Member

merriemcgaw commented Nov 7, 2019

We should file a follow up issue that changes the folder picker to the newer one that Oren enabled way back when we first went open source.

@RussKie RussKie changed the title Porting SelectedPathEditor Port SelectedPathEditor Nov 7, 2019
@RussKie RussKie merged commit 2422f9a into release/3.1-uitypeeditors Nov 7, 2019
5 checks passed
5 checks passed
WIP Ready for review
Details
dotnet-winforms CI Build #20191107.18 succeeded
Details
dotnet-winforms CI (Build Windows Debug) Build Windows Debug succeeded
Details
dotnet-winforms CI (Build Windows Release) Build Windows Release succeeded
Details
license/cla All CLA requirements met.
Details
@RussKie RussKie deleted the dev/v-vlkres/EditorsPort/SelectedPathEditor branch Nov 7, 2019
RussKie added a commit that referenced this pull request Nov 8, 2019
RussKie added a commit that referenced this pull request Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.