Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port HelpNamespaceEditor #2306

Conversation

@vladimir-krestov
Copy link
Contributor

vladimir-krestov commented Nov 6, 2019

Fixes #2283
Related issue #1115

Proposed changes

  • Port HelpNamespaceEditor
  • Add TypeForwardedTo statement for HelpNamespaceEditor
  • Make code refactoring
  • Add a unit test case to check HelpNamespaceEditor

Customer Impact

  • Changed HelpNamespace editor to compliance with .Net 4.8.

Regression?

  • Yes

Risk

  • Low

Screenshots

Before

image

After

image

Test methodology

  • Manual UI testing
  • CTI
  • Unit testing

Test environment(s)

  • .Net Core version: 3.1.0-preview3.19553.2
  • Microsoft Windows [Version 10.0.18362.418]
Microsoft Reviewers: Open in CodeFlow
@vladimir-krestov vladimir-krestov requested a review from dotnet/dotnet-winforms as a code owner Nov 6, 2019
@vladimir-krestov vladimir-krestov self-assigned this Nov 6, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #2306 into release/3.1-uitypeeditors will increase coverage by 0.00658%.
The diff coverage is 0%.

@@                         Coverage Diff                         @@
##           release/3.1-uitypeeditors       #2306         +/-   ##
===================================================================
+ Coverage                   26.37784%   26.38443%   +0.00659%     
===================================================================
  Files                            820         819          -1     
  Lines                         269878      269731        -147     
  Branches                       38270       38260         -10     
===================================================================
- Hits                           71188       71167         -21     
+ Misses                        193615      193487        -128     
- Partials                        5075        5077          +2
Flag Coverage Δ
#Debug 26.38443% <0%> (+0.00658%) ⬆️
#production 26.38443% <0%> (+0.00658%) ⬆️
#test 100% <ø> (ø) ⬆️
@vladimir-krestov

This comment has been minimized.

Copy link
Contributor Author

vladimir-krestov commented Nov 7, 2019

Testers approved these changes ✔️

@vladimir-krestov vladimir-krestov changed the title WIP: Porting HelpNamespaceEditor Porting HelpNamespaceEditor Nov 7, 2019
@vladimir-krestov vladimir-krestov force-pushed the dev/v-vlkres/EditorsPort/HelpNamespaceEditor branch from 15bbccd to a2c8ebf Nov 7, 2019
Fixes issue #2283
Made code refactoring
Added unit test cases
@RussKie RussKie force-pushed the dev/v-vlkres/EditorsPort/HelpNamespaceEditor branch from a2c8ebf to 2d8ef45 Nov 7, 2019
@RussKie RussKie changed the title Porting HelpNamespaceEditor Port HelpNamespaceEditor Nov 7, 2019
@RussKie RussKie merged commit 53e9d41 into release/3.1-uitypeeditors Nov 7, 2019
5 checks passed
5 checks passed
WIP Ready for review
Details
dotnet-winforms CI Build #20191107.34 succeeded
Details
dotnet-winforms CI (Build Windows Debug) Build Windows Debug succeeded
Details
dotnet-winforms CI (Build Windows Release) Build Windows Release succeeded
Details
license/cla All CLA requirements met.
Details
@RussKie RussKie deleted the dev/v-vlkres/EditorsPort/HelpNamespaceEditor branch Nov 7, 2019
RussKie added a commit that referenced this pull request Nov 8, 2019
RussKie added a commit that referenced this pull request Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.