Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structify CONTROLINFO #2307

Merged
merged 1 commit into from Nov 7, 2019

Conversation

@hughbe
Copy link
Contributor

hughbe commented Nov 6, 2019

Proposed Changes

  • Structify CONTROLINFO
  • Make CTRLINFO_ constants into enum
  • Cleanup IOleControl interface
Microsoft Reviewers: Open in CodeFlow
@hughbe hughbe requested a review from dotnet/dotnet-winforms as a code owner Nov 6, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #2307 into master will increase coverage by 0.14492%.
The diff coverage is 6.06061%.

@@                Coverage Diff                 @@
##             master       #2307         +/-   ##
==================================================
+ Coverage   29.3821%   29.52703%   +0.14493%     
==================================================
  Files           943         943                 
  Lines        266550      266549          -1     
  Branches      37936       37938          +2     
==================================================
+ Hits          78318       78704        +386     
+ Misses       183035      182628        -407     
- Partials       5197        5217         +20
Flag Coverage Δ
#Debug 29.52703% <6.06061%> (+0.14492%) ⬆️
#production 29.52703% <6.06061%> (+0.14492%) ⬆️
#test ?
@RussKie
RussKie approved these changes Nov 7, 2019
@RussKie RussKie added the enhancement label Nov 7, 2019
@RussKie RussKie merged commit 732e844 into dotnet:master Nov 7, 2019
5 checks passed
5 checks passed
WIP Ready for review
Details
dotnet-winforms CI Build #20191106.28 succeeded
Details
dotnet-winforms CI (Build Windows Debug) Build Windows Debug succeeded
Details
dotnet-winforms CI (Build Windows Release) Build Windows Release succeeded
Details
license/cla All CLA requirements met.
Details
@msftbot msftbot bot added this to the 5.0 milestone Nov 7, 2019
@hughbe hughbe deleted the hughbe:CONTROLINFO branch Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.