Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port FormatStringEditor #2308

Conversation

@vladimir-krestov
Copy link
Contributor

vladimir-krestov commented Nov 6, 2019

Fixes #2281
Related issue #1115
Related PR #2287

Proposed changes

  • Port FormatStringEditor
  • Make code refactoring
  • Add TypeForwardedTo statement for FormatStringEditor
  • Add unit tests cases

Customer Impact

  • Changed FormatStringEditor editor to compliance with .Net 4.8.

Regression?

  • Yes

Risk

  • Low

Screenshots

Before

image

After

image

Test methodology

  • Manual UI testing
  • CTI
  • Unit testing

Test environment(s)

  • .Net Core version: 3.1.0-preview3.19553.2
  • Microsoft Windows [Version 10.0.18362.418]
Microsoft Reviewers: Open in CodeFlow
@vladimir-krestov vladimir-krestov requested a review from dotnet/dotnet-winforms as a code owner Nov 6, 2019
@vladimir-krestov vladimir-krestov self-assigned this Nov 6, 2019
@vladimir-krestov vladimir-krestov changed the title Porting FormatStringEditor WIP: Porting FormatStringEditor Nov 6, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #2308 into release/3.1-uitypeeditors will decrease coverage by 0.14996%.
The diff coverage is 0%.

@@                         Coverage Diff                         @@
##           release/3.1-uitypeeditors       #2308         +/-   ##
===================================================================
- Coverage                   26.36302%   26.21306%   -0.14997%     
===================================================================
  Files                            820         824          +4     
  Lines                         269878      270968       +1090     
  Branches                       38270       38365         +95     
===================================================================
- Hits                           71148       71029        -119     
- Misses                        193651      194859       +1208     
- Partials                        5079        5080          +1
Flag Coverage Δ
#Debug 26.21306% <0%> (-0.14997%) ⬇️
#production 26.21306% <0%> (-0.14997%) ⬇️
#test ?
@RussKie RussKie force-pushed the dev/v-vlkres/EditorsPort/FormatStringEditor branch from d2c9fe0 to 051a696 Nov 7, 2019
@vladimir-krestov

This comment has been minimized.

Copy link
Contributor Author

vladimir-krestov commented Nov 7, 2019

Thanks for the cleanup!

@vladimir-krestov

This comment has been minimized.

Copy link
Contributor Author

vladimir-krestov commented Nov 7, 2019

Testers approved these changes ✔️

@vladimir-krestov vladimir-krestov force-pushed the dev/v-vlkres/EditorsPort/FormatStringEditor branch from 051a696 to 18217fc Nov 7, 2019
@vladimir-krestov vladimir-krestov changed the title WIP: Porting FormatStringEditor Porting FormatStringEditor Nov 7, 2019
… cleanup Added unit test cases Removed BindingFormatingDialog and its related types and resources
@RussKie RussKie force-pushed the dev/v-vlkres/EditorsPort/FormatStringEditor branch from 18217fc to 33d0ac1 Nov 7, 2019
@RussKie RussKie changed the title Porting FormatStringEditor Port FormatStringEditor Nov 7, 2019
@RussKie RussKie merged commit 433a09c into release/3.1-uitypeeditors Nov 7, 2019
5 checks passed
5 checks passed
WIP Ready for review
Details
dotnet-winforms CI Build #20191107.32 succeeded
Details
dotnet-winforms CI (Build Windows Debug) Build Windows Debug succeeded
Details
dotnet-winforms CI (Build Windows Release) Build Windows Release succeeded
Details
license/cla All CLA requirements met.
Details
@RussKie RussKie deleted the dev/v-vlkres/EditorsPort/FormatStringEditor branch Nov 7, 2019
RussKie added a commit that referenced this pull request Nov 8, 2019
RussKie added a commit that referenced this pull request Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.