Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NotifyIcon tests #2315

Merged
merged 1 commit into from Nov 8, 2019

Conversation

@hughbe
Copy link
Contributor

hughbe commented Nov 7, 2019

Proposed Changes

  • Add NotifyIcon tests
Microsoft Reviewers: Open in CodeFlow
@hughbe hughbe requested a review from dotnet/dotnet-winforms as a code owner Nov 7, 2019
@hughbe hughbe force-pushed the hughbe:NotifyIcon-tests branch from 91d678e to 5bd0b0f Nov 7, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 7, 2019

Codecov Report

Merging #2315 into master will increase coverage by 0.08779%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##              master       #2315         +/-   ##
===================================================
+ Coverage   29.36198%   29.44977%   +0.08779%     
===================================================
  Files            945         945                 
  Lines         266559      266559                 
  Branches       37938       37938                 
===================================================
+ Hits           78267       78501        +234     
+ Misses        183100      182864        -236     
- Partials        5192        5194          +2
Flag Coverage Δ
#Debug 29.44977% <ø> (+0.08779%) ⬆️
#production 29.44977% <ø> (+0.08779%) ⬆️
#test 100% <ø> (?)
@hughbe hughbe force-pushed the hughbe:NotifyIcon-tests branch from 5bd0b0f to 3d0ed4d Nov 7, 2019
@RussKie
RussKie approved these changes Nov 8, 2019
@RussKie RussKie merged commit 8b1d5c5 into dotnet:master Nov 8, 2019
5 checks passed
5 checks passed
WIP Ready for review
Details
dotnet-winforms CI Build #20191107.24 succeeded
Details
dotnet-winforms CI (Build Windows Debug) Build Windows Debug succeeded
Details
dotnet-winforms CI (Build Windows Release) Build Windows Release succeeded
Details
license/cla All CLA requirements met.
Details
@msftbot msftbot bot added this to the 5.0 milestone Nov 8, 2019
@hughbe hughbe deleted the hughbe:NotifyIcon-tests branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.