Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Update dependencies from dotnet/arcade #2317

Merged
merged 4 commits into from Nov 11, 2019

Conversation

@dotnet-maestro
Copy link
Contributor

dotnet-maestro bot commented Nov 8, 2019

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Build: 20191108.11
  • Date Produced: 11/8/2019 11:23 PM
  • Commit: be7971c98d4ad60cdf8c3d1aa41f950f42bd466a
  • Branch: refs/heads/master
  • Updates:
    • Microsoft.DotNet.XUnitExtensions -> 5.0.0-beta.19558.11
    • Microsoft.DotNet.Arcade.Sdk -> 5.0.0-beta.19558.11
    • Microsoft.DotNet.Helix.Sdk -> 5.0.0-beta.19558.11
    • Microsoft.DotNet.GenFacades -> 5.0.0-beta.19558.11
Microsoft Reviewers: Open in CodeFlow
…107.20

- Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.19557.20
- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19557.20
- Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.19557.20
- Microsoft.DotNet.GenFacades - 5.0.0-beta.19557.20
@dotnet-maestro dotnet-maestro bot requested a review from dotnet/dotnet-winforms as a code owner Nov 8, 2019
@dotnet-maestro

This comment has been minimized.

Copy link
Contributor Author

dotnet-maestro bot commented Nov 8, 2019

Auto-Merge Status

This pull request will be merged because the following merge policies have succeeded.

  • ✔️ All Checks Successful Succeeded - Successful checks: dotnet-winforms CI, dotnet-winforms CI (Build Windows Release), dotnet-winforms CI (Build Windows Debug)
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 8, 2019

Codecov Report

Merging #2317 into master will increase coverage by 0.1508%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##              master       #2317         +/-   ##
===================================================
+ Coverage   29.46526%   29.61607%   +0.15081%     
===================================================
  Files            945         945                 
  Lines         266558      266558                 
  Branches       37938       37938                 
===================================================
+ Hits           78542       78944        +402     
+ Misses        182822      182394        -428     
- Partials        5194        5220         +26
Flag Coverage Δ
#Debug 29.61607% <ø> (+0.1508%) ⬆️
#production 29.61607% <ø> (+0.1508%) ⬆️
#test 100% <ø> (?)
@dotnet-maestro

This comment has been minimized.

Copy link
Contributor Author

dotnet-maestro bot commented Nov 8, 2019

Auto-Merge Status

This pull request will be merged because the following merge policies have succeeded.

  • ✔️ All Checks Successful Succeeded - Successful checks: dotnet-winforms CI, dotnet-winforms CI (Build Windows Release), dotnet-winforms CI (Build Windows Debug)
Resolves the nuget.common load errors that are causing the official build to fail.
@mmitche mmitche requested a review from ericstj Nov 8, 2019
@mmitche

This comment has been minimized.

Copy link
Member

mmitche commented Nov 8, 2019

@ericstj I've updated the SDK to a slightly newer version here to avoid the NuGet.Common load errors. Appears that the winforms build hasn't passed in quite a while.

@dotnet-maestro

This comment has been minimized.

Copy link
Contributor Author

dotnet-maestro bot commented Nov 8, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Waiting on checks: dotnet-winforms CI, dotnet-winforms CI (Build Windows Release)
Copy link
Member

mmitche left a comment

no emrge

@mmitche

This comment has been minimized.

Copy link
Member

mmitche commented Nov 8, 2019

@AdamYoblick It appears the pack-sign-publish leg is failing in this, but not failing the build. Maybe the script

@dotnet-maestro

This comment has been minimized.

Copy link
Contributor Author

dotnet-maestro bot commented Nov 8, 2019

Auto-Merge Status

This pull request will be merged because the following merge policies have succeeded.

  • ✔️ All Checks Successful Succeeded - Successful checks: dotnet-winforms CI, dotnet-winforms CI (Build Windows Release), dotnet-winforms CI (Build Windows Debug)
…108.11

- Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.19558.11
- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19558.11
- Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.19558.11
- Microsoft.DotNet.GenFacades - 5.0.0-beta.19558.11
…aff06e
@RussKie

This comment has been minimized.

Copy link
Member

RussKie commented Nov 11, 2019

Looks good. Squash merge when ready

@dotnet-maestro

This comment has been minimized.

Copy link
Contributor Author

dotnet-maestro bot commented Nov 11, 2019

Auto-Merge Status

This pull request will be merged because the following merge policies have succeeded.

  • ✔️ All Checks Successful Succeeded - Successful checks: dotnet-winforms CI, dotnet-winforms CI (Build Windows Release), dotnet-winforms CI (Build Windows Debug)
@RussKie RussKie merged commit f8c77bb into master Nov 11, 2019
5 checks passed
5 checks passed
WIP Ready for review
Details
dotnet-winforms CI Build #20191110.8 succeeded
Details
dotnet-winforms CI (Build Windows Debug) Build Windows Debug succeeded
Details
dotnet-winforms CI (Build Windows Release) Build Windows Release succeeded
Details
license/cla All CLA requirements met.
Details
@RussKie RussKie deleted the darc-master-dd4cad06-cbc0-441b-bd8d-854c57aff06e branch Nov 11, 2019
@msftbot msftbot bot added this to the 5.0 milestone Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.