Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update #2436

merged 1 commit into from Nov 27, 2019


Copy link

RussKie commented Nov 27, 2019

Update testing guidelines

@hughbe is there anything else off the top your head worth adding?

Microsoft Reviewers: Open in CodeFlow
@RussKie RussKie requested a review from AdamYoblick Nov 27, 2019
@RussKie RussKie requested a review from dotnet/dotnet-winforms as a code owner Nov 27, 2019

This comment has been minimized.

Copy link

codecov bot commented Nov 27, 2019

Codecov Report

Merging #2436 into master will decrease coverage by 0.01811%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##              master       #2436         +/-   ##
- Coverage   28.95639%   28.93828%   -0.01811%     
  Files           1002        1002                 
  Lines         259542      259542                 
  Branches       36837       36837                 
- Hits           75154       75107         -47     
- Misses        179497      179534         +37     
- Partials        4891        4901         +10
Flag Coverage Δ
#Debug 28.93828% <ø> (-0.01812%) ⬇️
#production 28.93828% <ø> (-0.01812%) ⬇️
#test 100% <ø> (ø) ⬆️

This comment has been minimized.

Copy link

hughbe commented Nov 27, 2019

Looks good!

@RussKie RussKie merged commit 1cc18df into master Nov 27, 2019
5 checks passed
5 checks passed
WIP Ready for review
dotnet-winforms CI #20191126.24 succeeded
dotnet-winforms CI (Build Windows Debug) Build Windows Debug succeeded
dotnet-winforms CI (Build Windows Release) Build Windows Release succeeded
license/cla All CLA requirements met.
@RussKie RussKie deleted the RussKie-patch-1 branch Nov 27, 2019
@msftbot msftbot bot added this to the 5.0 milestone Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.