Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Type 'System.Windows.Forms.IWin32Window' is not defined #2442

Merged
merged 1 commit into from Nov 28, 2019

Conversation

@RussKie
Copy link
Member

RussKie commented Nov 28, 2019

Builds randomly fail with "Type 'System.Windows.Forms.IWin32Window' is not defined" error, estimated about 10% of builds failed because of this.

Investigations suggest that there may be MSBuild bug that GetCopyToOutputDirectoryItemsDependsOn property stomps over previous property value without including itself, thus leading to incorrect behaviours later in a build.
More info: microsoft/msbuild#4923 (comment)

Closes #2107

Microsoft Reviewers: Open in CodeFlow
Builds randomly fail with "Type 'System.Windows.Forms.IWin32Window' is
not defined" error, estimated about 10% of builds failed because of this.

Investigations suggest that there may be MSBuild bug that
`GetCopyToOutputDirectoryItemsDependsOn` property stomps over previous
property value without including itself, thus leading to incorrect behaviours
later in a build.
More info: microsoft/msbuild#4923 (comment)

Closes #2107
@RussKie RussKie requested review from KirillOsenkov and cston Nov 28, 2019
@RussKie RussKie requested a review from dotnet/dotnet-winforms as a code owner Nov 28, 2019
@RussKie

This comment has been minimized.

Copy link
Member Author

RussKie commented Nov 28, 2019

@KirillOsenkov I hope I interpreted your suggestion correctly.

@KirillOsenkov

This comment has been minimized.

Copy link
Member

KirillOsenkov commented Nov 28, 2019

Yes, looks correct. Now let's see if you CI feels better with this change!

@RussKie RussKie merged commit 0cd35ad into dotnet:master Nov 28, 2019
5 checks passed
5 checks passed
WIP Ready for review
Details
dotnet-winforms CI #20191127.23 succeeded
Details
dotnet-winforms CI (Build Windows Debug) Build Windows Debug succeeded
Details
dotnet-winforms CI (Build Windows Release) Build Windows Release succeeded
Details
license/cla All CLA requirements met.
@RussKie RussKie deleted the RussKie:fix_random_build_failures branch Nov 28, 2019
@msftbot msftbot bot added this to the 5.0 milestone Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.