Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WA enum to User32 #2445

Merged
merged 1 commit into from Nov 28, 2019

Conversation

@gpetrou
Copy link
Contributor

gpetrou commented Nov 28, 2019

Proposed changes

  • Add WA enum to User32
  • Remove the corresponding constants and replace their usages with the above enum.
Microsoft Reviewers: Open in CodeFlow
@gpetrou gpetrou requested a review from dotnet/dotnet-winforms as a code owner Nov 28, 2019
@gpetrou gpetrou force-pushed the gpetrou:WA branch 2 times, most recently from 98c8c08 to 4507476 Nov 28, 2019
@gpetrou gpetrou force-pushed the gpetrou:WA branch from 4507476 to f9f6766 Nov 28, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 28, 2019

Codecov Report

Merging #2445 into master will increase coverage by 0.02966%.
The diff coverage is 16.66667%.

@@                 Coverage Diff                 @@
##              master       #2445         +/-   ##
===================================================
+ Coverage   29.02834%   29.05801%   +0.02967%     
===================================================
  Files           1003        1003                 
  Lines         259505      259505                 
  Branches       36836       36836                 
===================================================
+ Hits           75330       75407         +77     
+ Misses        179264      179184         -80     
- Partials        4911        4914          +3
Flag Coverage Δ
#Debug 29.05801% <16.66667%> (+0.02966%) ⬆️
#production 29.05801% <16.66667%> (+0.02966%) ⬆️
#test 100% <ø> (ø) ⬆️
@RussKie RussKie added the enhancement label Nov 28, 2019
@RussKie RussKie merged commit 9bdd2e4 into dotnet:master Nov 28, 2019
5 checks passed
5 checks passed
WIP Ready for review
Details
dotnet-winforms CI #20191127.33 succeeded
Details
dotnet-winforms CI (Build Windows Debug) Build Windows Debug succeeded
Details
dotnet-winforms CI (Build Windows Release) Build Windows Release succeeded
Details
license/cla All CLA requirements met.
Details
@msftbot msftbot bot added this to the 5.0 milestone Nov 28, 2019
@gpetrou gpetrou deleted the gpetrou:WA branch Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.