Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SetWindowTheme to Interop UxTheme #2446

Merged
merged 1 commit into from Nov 28, 2019

Conversation

@gpetrou
Copy link
Contributor

gpetrou commented Nov 28, 2019

Proposed changes

  • Move SetWindowTheme to Interop UxTheme.
  • Remove some unused namespaces.
  • Fix GetCurrentThemeName return type.
Microsoft Reviewers: Open in CodeFlow
@gpetrou gpetrou requested a review from dotnet/dotnet-winforms as a code owner Nov 28, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 28, 2019

Codecov Report

Merging #2446 into master will decrease coverage by 0.0501%.
The diff coverage is 0%.

@@                Coverage Diff                 @@
##              master       #2446        +/-   ##
==================================================
- Coverage   29.04453%   28.99443%   -0.0501%     
==================================================
  Files           1003        1003                
  Lines         259505      259505                
  Branches       36836       36836                
==================================================
- Hits           75372       75242       -130     
- Misses        179223      179353       +130     
  Partials        4910        4910
Flag Coverage Δ
#Debug 28.99443% <0%> (-0.05011%) ⬇️
#production 28.99443% <0%> (-0.05011%) ⬇️
#test 100% <ø> (ø) ⬆️
@gpetrou gpetrou force-pushed the gpetrou:SetWindowTheme branch from 8a85495 to da0f0aa Nov 28, 2019
@RussKie RussKie added the enhancement label Nov 28, 2019
@RussKie RussKie merged commit ed9b05a into dotnet:master Nov 28, 2019
5 checks passed
5 checks passed
WIP Ready for review
Details
dotnet-winforms CI #20191128.16 succeeded
Details
dotnet-winforms CI (Build Windows Debug) Build Windows Debug succeeded
Details
dotnet-winforms CI (Build Windows Release) Build Windows Release succeeded
Details
license/cla All CLA requirements met.
Details
@msftbot msftbot bot added this to the 5.0 milestone Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.