Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move GetAncestor to Interop User32 and add GA enum #2452

Merged
merged 1 commit into from Dec 1, 2019

Conversation

@gpetrou
Copy link
Contributor

gpetrou commented Nov 29, 2019

Proposed changes

  • Move GetAncestor to Interop User32.
  • Add GA enum.
  • Remove GA constants and replace their usages with the above enum.
Microsoft Reviewers: Open in CodeFlow
@gpetrou gpetrou requested a review from dotnet/dotnet-winforms as a code owner Nov 29, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 29, 2019

Codecov Report

Merging #2452 into master will decrease coverage by 0.00634%.
The diff coverage is 70%.

@@                 Coverage Diff                 @@
##              master       #2452         +/-   ##
===================================================
- Coverage   29.22201%   29.21567%   -0.00634%     
===================================================
  Files           1003        1004          +1     
  Lines         259503      259508          +5     
  Branches       36836       36836                 
===================================================
- Hits           75832       75817         -15     
- Misses        178763      178780         +17     
- Partials        4908        4911          +3
Flag Coverage Δ
#Debug 29.21567% <70%> (-0.00635%) ⬇️
#production 29.21567% <70%> (-0.00635%) ⬇️
#test 100% <ø> (ø) ⬆️
@gpetrou gpetrou force-pushed the gpetrou:GetAncestor branch from 86fbb8e to 1dbf05c Dec 1, 2019
@RussKie
RussKie approved these changes Dec 1, 2019
@RussKie RussKie added the enhancement label Dec 1, 2019
@RussKie RussKie merged commit 2f36715 into dotnet:master Dec 1, 2019
5 checks passed
5 checks passed
WIP Ready for review
Details
dotnet-winforms CI #20191201.2 succeeded
Details
dotnet-winforms CI (Build Windows Debug) Build Windows Debug succeeded
Details
dotnet-winforms CI (Build Windows Release) Build Windows Release succeeded
Details
license/cla All CLA requirements met.
Details
@msftbot msftbot bot added this to the 5.0 milestone Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.