Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates from Arcade #2458

Draft
wants to merge 7 commits into
base: master
from

Conversation

@chcosta
Copy link
Member

chcosta commented Dec 2, 2019

Validating Arcade script changes

Microsoft Reviewers: Open in CodeFlow
@chcosta chcosta force-pushed the chcosta:test-telem-script branch from 35347fe to a59a490 Dec 2, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 2, 2019

Codecov Report

Merging #2458 into master will increase coverage by 0.01011%.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##              master       #2458        +/-   ##
==================================================
+ Coverage   29.44885%   29.45896%   +0.0101%     
==================================================
  Files           1005        1005                
  Lines         259623      259629         +6     
  Branches       36853       36855         +2     
==================================================
+ Hits           76456       76484        +28     
+ Misses        178232      178213        -19     
+ Partials        4935        4932         -3
Flag Coverage Δ
#Debug 29.45896% <ø> (+0.01011%) ⬆️
#production 29.45896% <ø> (+0.01011%) ⬆️
@RussKie

This comment has been minimized.

Copy link
Member

RussKie commented Dec 3, 2019

Why are we insisting that a tool must have an executable?

$ToolFilePath = Get-ChildItem $ToolInstallDirectory -Recurse -Filter "$ToolName.exe" | % { $_.FullName }
if (@($ToolFilePath).Length -Gt 1) {
Write-Error "There are multiple copies of $ToolName in $($ToolInstallDirectory): `n$(@($ToolFilePath | out-string))"
exit 1
} elseif (@($ToolFilePath).Length -Lt 1) {
Write-Error "$ToolName was not found in $ToolFilePath."
exit 1
}

As an alternative, can we have a new node "intellisense" (short of a good name) at the same level as "native-tools" that is downloaded but not requiring an ".exe"?

chcosta added 5 commits Dec 3, 2019
@RussKie

This comment has been minimized.

Copy link
Member

RussKie commented Dec 3, 2019

If it builds - works for me 👍

@RussKie

This comment has been minimized.

Copy link
Member

RussKie commented Dec 5, 2019

Can this be closed now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.