Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update issue templates #2681

Merged
merged 3 commits into from Jan 13, 2020
Merged

Update issue templates #2681

merged 3 commits into from Jan 13, 2020

Conversation

@RussKie
Copy link
Member

RussKie commented Jan 10, 2020

Microsoft Reviewers: Open in CodeFlow
@RussKie RussKie requested a review from dotnet/dotnet-winforms as a code owner Jan 10, 2020
@RussKie RussKie force-pushed the update-issue-templates branch from a65bc8a to 2d614dc Jan 10, 2020
@RussKie RussKie force-pushed the update-issue-templates branch from 2d614dc to a29eebd Jan 10, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 10, 2020

Codecov Report

Merging #2681 into master will increase coverage by 0.00268%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##              master       #2681         +/-   ##
===================================================
+ Coverage   57.59206%   57.59474%   +0.00268%     
===================================================
  Files           1235        1239          +4     
  Lines         418358      418349          -9     
  Branches       38813       38812          -1     
===================================================
+ Hits          240941      240947          +6     
+ Misses        172048      172027         -21     
- Partials        5369        5375          +6
Flag Coverage Δ
#Debug 57.59474% <ø> (+0.00268%) ⬆️
#production 31.31664% <ø> (+0.00345%) ⬆️
#test 98.93347% <ø> (ø) ⬆️
Copy link
Contributor

vladimir-krestov left a comment

It has some typos.
I like the new structure of the template.

.github/ISSUE_TEMPLATE/feature_request.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.md Outdated Show resolved Hide resolved
Copy link
Member

merriemcgaw left a comment

Looks good. Do we want to update the contribution guidelines too?

Co-Authored-By: vladimir-krestov <49272759+vladimir-krestov@users.noreply.github.com>
@RussKie RussKie dismissed stale reviews from merriemcgaw and AdamYoblick via 0c5214e Jan 13, 2020
Co-Authored-By: vladimir-krestov <49272759+vladimir-krestov@users.noreply.github.com>
@RussKie

This comment has been minimized.

Copy link
Member Author

RussKie commented Jan 13, 2020

Do we want to update the contribution guidelines too?

The guide has the following wording, which I think is sufficient:

Please file an issue for any larger change you would like to propose. Please choose the template most appropriate for the issue type.

I'm happy to update/alter it, if you think it is necessary. Suggestions are welcome.

@RussKie RussKie merged commit 367150c into master Jan 13, 2020
5 checks passed
5 checks passed
WIP Ready for review
Details
dotnet-winforms CI Build #20200112.13 succeeded
Details
dotnet-winforms CI (Build Windows Debug) Build Windows Debug succeeded
Details
dotnet-winforms CI (Build Windows Release) Build Windows Release succeeded
Details
license/cla All CLA requirements met.
Details
@RussKie RussKie deleted the update-issue-templates branch Jan 13, 2020
@msftbot msftbot bot added this to the 5.0 milestone Jan 13, 2020
@RussKie RussKie removed this from the 5.0 milestone Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.