Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ListBox/ComboBox tests and cleanup ListBox.SendMessage overloads #2703

Merged
merged 3 commits into from Jan 20, 2020

Conversation

@hughbe
Copy link
Contributor

hughbe commented Jan 13, 2020

Proposed Changes

  • Add ListBox/ComboBox tests
  • Cleanup ListBox.SendMessage overloads
Microsoft Reviewers: Open in CodeFlow
@hughbe hughbe requested a review from dotnet/dotnet-winforms as a code owner Jan 13, 2020
@hughbe hughbe force-pushed the hughbe:ListBox-ComboBox branch 5 times, most recently from 1c00265 to 19d7fc5 Jan 14, 2020
@hughbe hughbe force-pushed the hughbe:ListBox-ComboBox branch 3 times, most recently from fbac65e to 15b31c1 Jan 15, 2020
@hughbe hughbe force-pushed the hughbe:ListBox-ComboBox branch from 15b31c1 to 2b2977c Jan 15, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 15, 2020

Codecov Report

Merging #2703 into master will increase coverage by 0.46797%.
The diff coverage is 80.74074%.

@@                 Coverage Diff                 @@
##              master       #2703         +/-   ##
===================================================
+ Coverage   58.15281%   58.62078%   +0.46797%     
===================================================
  Files           1240        1240                 
  Lines         422989      426632       +3643     
  Branches       38851       38906         +55     
===================================================
+ Hits          245980      250095       +4115     
+ Misses        171637      171188        -449     
+ Partials        5372        5349         -23
Flag Coverage Δ
#Debug 58.62078% <80.74074%> (+0.46797%) ⬆️
#production 31.69875% <52.38095%> (+0.21085%) ⬆️
#test 98.91905% <89.37198%> (-0.01064%) ⬇️
@RussKie RussKie merged commit 7bdaad1 into dotnet:master Jan 20, 2020
5 checks passed
5 checks passed
WIP Ready for review
Details
dotnet-winforms CI Build #20200115.7 succeeded
Details
dotnet-winforms CI (Build Windows Debug) Build Windows Debug succeeded
Details
dotnet-winforms CI (Build Windows Release) Build Windows Release succeeded
Details
license/cla All CLA requirements met.
Details
@msftbot msftbot bot added this to the 5.0 milestone Jan 20, 2020
@hughbe hughbe deleted the hughbe:ListBox-ComboBox branch Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.