Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request #2707 from RussKie/Unblock_flow_to_WindowsDesktop #2707

Merged
merged 2 commits into from Jan 14, 2020

Conversation

@RussKie
Copy link
Member

RussKie commented Jan 14, 2020

Proposed changes

  • Ship WinForms references in transport package

    Enables dotnet/windowsdesktop#365

    To reduce the x-repo overhead of managing Windows Forms assemblies ship the list of assemblies in our transport package.
    This will allow for a simpler ingestion by WindowsDesktop repo, yet retains ability to break ingestion if the list of assemblies is outdated.

  • Revert to #2497 (revert to versions to f3ac126 level)

    Revert versions to f3ac126 level, where MicrosoftNETCoreApppackageVersion=5.0.0-alpha1.19514.1 until dotnet/wpf#2399 (comment) is resolved.
    This version is very likely compatible with the WPF repo right now.

    Enables dotnet/wpf#2399

Microsoft Reviewers: Open in CodeFlow
Enables dotnet/windowsdesktop#365

To reduce the x-repo overhead of managing Windows Forms assemblies
ship the list of assemblies in our transport package.

This will allow for a simpler ingestion by WindowsDesktop repo, yet retains
ability to break ingestion, if the list of assemblies is outdated.
@RussKie RussKie requested a review from dotnet/dotnet-winforms as a code owner Jan 14, 2020
@RussKie RussKie force-pushed the RussKie:Unblock_flow_to_WindowsDesktop branch from 346c2fd to 4114851 Jan 14, 2020
@RussKie RussKie closed this Jan 14, 2020
@RussKie RussKie reopened this Jan 14, 2020
Revert versions to f3ac126 level, where MicrosoftNETCoreApppackageVersion=5.0.0-alpha1.19514.1
until dotnet/wpf#2399 (comment) is resolved.

This version is very likely compatible with the WPF repo right now.
@RussKie RussKie force-pushed the RussKie:Unblock_flow_to_WindowsDesktop branch from 4114851 to f8a529e Jan 14, 2020
@RussKie RussKie changed the title Unblock flow to windows desktop Merge pull request #2707 from RussKie/Unblock_flow_to_WindowsDesktop Jan 14, 2020
@RussKie RussKie merged commit ab540a6 into dotnet:master Jan 14, 2020
5 checks passed
5 checks passed
WIP Ready for review
Details
dotnet-winforms CI Build #20200113.16 succeeded
Details
dotnet-winforms CI (Build Windows Debug) Build Windows Debug succeeded
Details
dotnet-winforms CI (Build Windows Release) Build Windows Release succeeded
Details
license/cla All CLA requirements met.
Details
@RussKie RussKie deleted the RussKie:Unblock_flow_to_WindowsDesktop branch Jan 14, 2020
@msftbot msftbot bot added this to the 5.0 milestone Jan 14, 2020
@RussKie

This comment has been minimized.

Copy link
Member Author

RussKie commented Jan 14, 2020

@vatsan-madhavan this should get us moving

@vatsan-madhavan

This comment has been minimized.

Copy link
Member

vatsan-madhavan commented Jan 14, 2020

/cc @rladuca

@vatsan-madhavan

This comment has been minimized.

Copy link
Member

vatsan-madhavan commented Jan 14, 2020

I’ve closed dotnet/wpf#2399. Let’s kick a new darc pr (or let maestro do it in its own course overnight)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.