Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TextBoxBase NREs #2829

Merged
merged 1 commit into from Feb 12, 2020
Merged

Fix TextBoxBase NREs #2829

merged 1 commit into from Feb 12, 2020

Conversation

@hughbe
Copy link
Contributor

hughbe commented Feb 9, 2020

Proposed Changes

  • Fix TextBoxBase NREs
Microsoft Reviewers: Open in CodeFlow
@hughbe hughbe requested a review from dotnet/dotnet-winforms as a code owner Feb 9, 2020
@msftbot msftbot bot assigned hughbe Feb 9, 2020
@hughbe hughbe force-pushed the hughbe:Fix-AppendTextNRE branch from b49997d to a0bb617 Feb 9, 2020
@hughbe hughbe force-pushed the hughbe:Fix-AppendTextNRE branch from a0bb617 to cdefa7a Feb 11, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 11, 2020

Codecov Report

Merging #2829 into master will increase coverage by 0.0173%.
The diff coverage is 66.66667%.

@@                Coverage Diff                 @@
##              master       #2829        +/-   ##
==================================================
+ Coverage   59.52728%   59.54458%   +0.0173%     
==================================================
  Files           1236        1236                
  Lines         429934      429930         -4     
  Branches       38787       38788         +1     
==================================================
+ Hits          255928      256000        +72     
+ Misses        168636      168555        -81     
- Partials        5370        5375         +5
Flag Coverage Δ
#Debug 59.54458% <66.66667%> (+0.0173%) ⬆️
#production 32.24219% <57.69231%> (+0.03072%) ⬆️
#test 98.96825% <100%> (-0.00004%) ⬇️
@RussKie RussKie added the enhancement label Feb 12, 2020
@RussKie RussKie merged commit efa4f39 into dotnet:master Feb 12, 2020
5 checks passed
5 checks passed
WIP Ready for review
Details
dotnet-winforms CI Build #20200211.7 succeeded
Details
dotnet-winforms CI (Build Windows Debug) Build Windows Debug succeeded
Details
dotnet-winforms CI (Build Windows Release) Build Windows Release succeeded
Details
license/cla All CLA requirements met.
Details
@msftbot msftbot bot added this to the 5.0 milestone Feb 12, 2020
@hughbe hughbe deleted the hughbe:Fix-AppendTextNRE branch Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.