Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ToolStripRenderer NREs #2830

Merged
merged 1 commit into from Feb 14, 2020
Merged

Fix ToolStripRenderer NREs #2830

merged 1 commit into from Feb 14, 2020

Conversation

@hughbe
Copy link
Contributor

hughbe commented Feb 9, 2020

Proposed Changes

  • Fix ToolStripRenderer NREs
Microsoft Reviewers: Open in CodeFlow
@hughbe hughbe requested a review from dotnet/dotnet-winforms as a code owner Feb 9, 2020
@msftbot msftbot bot assigned hughbe Feb 9, 2020
@hughbe hughbe force-pushed the hughbe:ToolStripRenderer-NREs branch from 7903d2d to a184f41 Feb 9, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 9, 2020

Codecov Report

Merging #2830 into master will increase coverage by 0.09670%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##              master       #2830         +/-   ##
===================================================
+ Coverage   59.43311%   59.52981%   +0.09669%     
===================================================
  Files           1236        1238          +2     
  Lines         429535      429788        +253     
  Branches       38780       38789          +9     
===================================================
+ Hits          255286      255852        +566     
+ Misses        168887      168559        -328     
- Partials        5362        5377         +15     
Flag Coverage Δ
#Debug 59.52981% <100.00000%> (+0.09669%) ⬆️
#production 32.19151% <100.00000%> (+0.05602%) ⬆️
#test 98.96848% <100.00000%> (-0.00097%) ⬇️
@hughbe hughbe force-pushed the hughbe:ToolStripRenderer-NREs branch from a184f41 to dca6eb0 Feb 13, 2020
@RussKie

This comment has been minimized.

Copy link
Member

RussKie commented Feb 14, 2020

We need to do the same for the other renderers as well

@RussKie RussKie merged commit eb88615 into dotnet:master Feb 14, 2020
5 checks passed
5 checks passed
WIP Ready for review
Details
dotnet-winforms CI Build #20200213.4 succeeded
Details
dotnet-winforms CI (Build Windows Debug) Build Windows Debug succeeded
Details
dotnet-winforms CI (Build Windows Release) Build Windows Release succeeded
Details
license/cla All CLA requirements met.
Details
@msftbot msftbot bot added this to the 5.0 milestone Feb 14, 2020
@RussKie

This comment has been minimized.

Copy link
Member

RussKie commented Feb 14, 2020

@hughbe hughbe deleted the hughbe:ToolStripRenderer-NREs branch Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.