Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HT enum in Interop User32 #2836

Merged
merged 1 commit into from Feb 10, 2020
Merged

Add HT enum in Interop User32 #2836

merged 1 commit into from Feb 10, 2020

Conversation

@gpetrou
Copy link
Contributor

gpetrou commented Feb 9, 2020

Proposed changes

  • Add HT enum in Interop User32.
  • Remove HT constants and replace their usages with the above enum values.
Microsoft Reviewers: Open in CodeFlow
@gpetrou gpetrou requested a review from dotnet/dotnet-winforms as a code owner Feb 9, 2020
@msftbot msftbot bot assigned gpetrou Feb 9, 2020
@gpetrou gpetrou force-pushed the gpetrou:HT branch from 7e7fa8f to 6505106 Feb 9, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 9, 2020

Codecov Report

Merging #2836 into master will decrease coverage by 0.01966%.
The diff coverage is 4.7619%.

@@                 Coverage Diff                 @@
##              master       #2836         +/-   ##
===================================================
- Coverage   59.45618%   59.43652%   -0.01966%     
===================================================
  Files           1236        1236                 
  Lines         429518      429512          -6     
  Branches       38778       38778                 
===================================================
- Hits          255375      255287         -88     
- Misses        168787      168856         +69     
- Partials        5356        5369         +13
Flag Coverage Δ
#Debug 59.43652% <4.7619%> (-0.01967%) ⬇️
#production 32.13879% <4.7619%> (-0.03388%) ⬇️
#test 98.96944% <ø> (ø) ⬆️
Copy link
Member

RussKie left a comment

👍 with few questions

@RussKie RussKie added the enhancement label Feb 10, 2020
@gpetrou gpetrou force-pushed the gpetrou:HT branch from 6505106 to 20ab6f9 Feb 10, 2020
@RussKie RussKie merged commit 3d79220 into dotnet:master Feb 10, 2020
5 checks passed
5 checks passed
WIP Ready for review
Details
dotnet-winforms CI Build #20200209.28 succeeded
Details
dotnet-winforms CI (Build Windows Debug) Build Windows Debug succeeded
Details
dotnet-winforms CI (Build Windows Release) Build Windows Release succeeded
Details
license/cla All CLA requirements met.
Details
@msftbot msftbot bot added this to the 5.0 milestone Feb 10, 2020
@gpetrou gpetrou deleted the gpetrou:HT branch Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.