Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] Fixing a default accessible name of a list of a dropdown entry value in PropertyGridView #2843

Conversation

@vladimir-krestov
Copy link
Contributor

vladimir-krestov commented Feb 11, 2020

Fixes #2802

Proposed changes

  • Use a PropertyGrid entry name if a list AccessibleName isn't set

Customer Impact

  • A user can see a non-empty accessible name of a values list using Inspect
    (Does not affect Narrator announcing)
  • Fixed MAS requirement:
    image

Regression?

  • No

Risk

  • Minimal

Screenshots

Before

  • An empty AccessibleName
    image

After

  • A non-empty AccessibleName ("{Property name}" -> "{Property name} property values")
    image

Test methodology

  • CTI
  • Unit testing

Accessibility testing

  • Using Narrator, Accessibility Insights and Inspect

Test environment(s)

  • .NET Core SDK: 5.0.0-alpha.1.20072.3
  • Microsoft Windows [Version 10.0.18363.592]
Microsoft Reviewers: Open in CodeFlow
@vladimir-krestov vladimir-krestov requested a review from dotnet/dotnet-winforms as a code owner Feb 11, 2020
@vladimir-krestov vladimir-krestov changed the title [Accessibility] Fixing a default accessible name of a list of a dropdown entry value in PropertyGridView WIP: [Accessibility] Fixing a default accessible name of a list of a dropdown entry value in PropertyGridView Feb 11, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 11, 2020

Codecov Report

Merging #2843 into master will increase coverage by 0.02651%.
The diff coverage is 92.30769%.

@@                 Coverage Diff                 @@
##              master       #2843         +/-   ##
===================================================
+ Coverage   59.83718%   59.86369%   +0.02651%     
===================================================
  Files           1241        1241                 
  Lines         431775      431801         +26     
  Branches       38811       38814          +3     
===================================================
+ Hits          258362      258492        +130     
+ Misses        168059      167953        -106     
- Partials        5354        5356          +2
Flag Coverage Δ
#Debug 59.86369% <92.30769%> (+0.02651%) ⬆️
#production 32.40659% <81.81818%> (+0.03603%) ⬆️
#test 98.98415% <100%> (+0.0113%) ⬆️
Copy link
Member

JuditRose left a comment

LGTM

@RussKie RussKie removed the waiting-review label Feb 13, 2020
Copy link
Member

Tanya-Solyanik left a comment

Looks good, I have a minor comment about the test only.

@vladimir-krestov

This comment has been minimized.

Copy link
Contributor Author

vladimir-krestov commented Feb 14, 2020

Will rebase and squash commits after testers approving.

@vladimir-krestov

This comment has been minimized.

Copy link
Contributor Author

vladimir-krestov commented Feb 17, 2020

Testers approved the fix. ✔️ Need a final review.

@vladimir-krestov vladimir-krestov force-pushed the vladimir-krestov:dev/v-vlkres/2802_PropertyGridItemMissingUIAName branch from 8fe5770 to 61bb3ab Feb 17, 2020
@vladimir-krestov vladimir-krestov changed the title WIP: [Accessibility] Fixing a default accessible name of a list of a dropdown entry value in PropertyGridView [Accessibility] Fixing a default accessible name of a list of a dropdown entry value in PropertyGridView Feb 17, 2020
@vladimir-krestov

This comment has been minimized.

Copy link
Contributor Author

vladimir-krestov commented Feb 19, 2020

The PR doesn't relate to #2870 because an app developer can't change GridViewListBox AccessibleName. It is possible internally.

of a list of a dropdown entry value in PropertyGrid
Fixes Issue #2802
@vladimir-krestov vladimir-krestov force-pushed the vladimir-krestov:dev/v-vlkres/2802_PropertyGridItemMissingUIAName branch from 61bb3ab to 3235b75 Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.