Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move EndDialog to Interop User32 #2850

Merged
merged 1 commit into from Feb 13, 2020
Merged

Move EndDialog to Interop User32 #2850

merged 1 commit into from Feb 13, 2020

Conversation

@gpetrou
Copy link
Contributor

gpetrou commented Feb 13, 2020

Proposed changes

  • Move EndDialog to Interop User32.
Microsoft Reviewers: Open in CodeFlow
@gpetrou gpetrou requested a review from dotnet/dotnet-winforms as a code owner Feb 13, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #2850 into master will increase coverage by 0.01%.
The diff coverage is 0%.

@@                 Coverage Diff                 @@
##              master       #2850         +/-   ##
===================================================
+ Coverage   59.52976%   59.53977%   +0.01001%     
===================================================
  Files           1237        1237                 
  Lines         429911      429911                 
  Branches       38783       38783                 
===================================================
+ Hits          255925      255968         +43     
+ Misses        168606      168571         -35     
+ Partials        5380        5372          -8
Flag Coverage Δ
#Debug 59.53977% <0%> (+0.01%) ⬆️
#production 32.2216% <0%> (+0.01694%) ⬆️
#test 98.96848% <ø> (ø) ⬆️
@RussKie RussKie merged commit 2f73fda into dotnet:master Feb 13, 2020
5 checks passed
5 checks passed
WIP Ready for review
Details
dotnet-winforms CI Build #20200212.12 succeeded
Details
dotnet-winforms CI (Build Windows Debug) Build Windows Debug succeeded
Details
dotnet-winforms CI (Build Windows Release) Build Windows Release succeeded
Details
license/cla All CLA requirements met.
Details
@msftbot msftbot bot added this to the 5.0 milestone Feb 13, 2020
@RussKie RussKie added the enhancement label Feb 13, 2020
@gpetrou gpetrou deleted the gpetrou:EndDialog branch Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.