Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DomainUpDown tests and remove dead code #2854

Merged
merged 2 commits into from Feb 18, 2020

Conversation

@hughbe
Copy link
Contributor

hughbe commented Feb 13, 2020

Proposed Changes

  • Add DomainUpDown tests and remove dead code
Microsoft Reviewers: Open in CodeFlow
@hughbe hughbe requested a review from dotnet/dotnet-winforms as a code owner Feb 13, 2020
@msftbot msftbot bot assigned hughbe Feb 13, 2020
@hughbe hughbe force-pushed the hughbe:DomainUpDown-tests branch from abe817e to 0f10a3e Feb 13, 2020
@hughbe hughbe force-pushed the hughbe:DomainUpDown-tests branch from 0f10a3e to e109c94 Feb 14, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 14, 2020

Codecov Report

Merging #2854 into master will increase coverage by 0.12847%.
The diff coverage is 98.82698%.

@@                 Coverage Diff                 @@
##              master       #2854         +/-   ##
===================================================
+ Coverage   59.52859%   59.65706%   +0.12847%     
===================================================
  Files           1238        1238                 
  Lines         429770      430742        +972     
  Branches       38783       38796         +13     
===================================================
+ Hits          255836      256968       +1132     
+ Misses        168552      168410        -142     
+ Partials        5382        5364         -18
Flag Coverage Δ
#Debug 59.65706% <98.82698%> (+0.12847%) ⬆️
#production 32.25898% <100%> (+0.0715%) ⬆️
#test 98.96728% <98.82468%> (-0.0012%) ⬇️

[WinFormsTheory]
[MemberData(nameof(Sorted_WithItemsWithSelection_TestData))]
public void DomainUpDown_Sorted_SetWithItemsWithSelectionWithHandle_GetReturnsExpected(bool userEdit, bool value, string[] expectedItems, int expectedSelectedIndex)

This comment has been minimized.

Copy link
@JuditRose

JuditRose Feb 14, 2020

Member

value could be sorted for better readability.

This comment has been minimized.

Copy link
@hughbe

hughbe Feb 16, 2020

Author Contributor

I do prefer value as this is the implicit name of C# property setter parameters. Also good to be consistent across corefx/winforms tests

Copy link
Member

JuditRose left a comment

LGTM besides my minor comments

@RussKie RussKie merged commit 111dedd into dotnet:master Feb 18, 2020
5 checks passed
5 checks passed
WIP Ready for review
Details
dotnet-winforms CI Build #20200214.2 succeeded
Details
dotnet-winforms CI (Build Windows Debug) Build Windows Debug succeeded
Details
dotnet-winforms CI (Build Windows Release) Build Windows Release succeeded
Details
license/cla All CLA requirements met.
Details
@msftbot msftbot bot added this to the 5.0 milestone Feb 18, 2020
@hughbe hughbe deleted the hughbe:DomainUpDown-tests branch Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.