New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect debug.asserts in table code #293

Merged
merged 1 commit into from Jan 7, 2019

Conversation

Projects
None yet
4 participants
@hughbe
Copy link
Contributor

hughbe commented Jan 4, 2019

Extracted from #285

  • All can be triggered from the tests in that PR

/cc @zsd4yr @sharwell

@hughbe hughbe requested a review from dotnet/dotnet-winforms as a code owner Jan 4, 2019

@JuditRose
Copy link
Member

JuditRose left a comment

LGTM

@sharwell
Copy link
Member

sharwell left a comment

Do you think any of these would be good indicators that a user has a bug in their application? If so, it might make sense to change them to Trace.WriteLine (or some other trace writer that a user can conditionally enable for downstream debugging scenarios).

@hughbe

This comment has been minimized.

Copy link
Contributor

hughbe commented Jan 5, 2019

@sharwell I haven't seen us do this anywhere else in winforms or corefx. I'm not sure they really indicate a bug in the program. The only one I can think of is if they call new RowStyle((SizeType)(SizeType.AutoSize - 1)) which previously triggered several of these asserts. That seems pretty unlikely.

@hughbe hughbe referenced this pull request Jan 5, 2019

Merged

Add table/layout tests #285

@zsd4yr zsd4yr merged commit af7cb0d into dotnet:master Jan 7, 2019

1 check passed

license/cla All CLA requirements met.
Details

@hughbe hughbe deleted the hughbe:table-debug-asserts branch Jan 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment