Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DataGridViewTextBoxEditingControl tests and fix bugs #2983

Merged
merged 1 commit into from Mar 21, 2020

Conversation

@hughbe
Copy link
Contributor

hughbe commented Mar 17, 2020

Proposed Changes

  • Add DataGridViewTextBoxEditingControl tests and fix bugs

Bugs Fixes

  • Validate dataGridViewCellStyle in ApplyCellStyleToEditingControl: fixes NRE
  • Fix NRE in NotifyDataGridViewOfValueChange without EditingControlDataGridView
  • Fix NRE in ApplyCellStyleToEditingControl without EditingControlDataGridView
  • Don't force handle creation in OnGotFocus or OnHandleCreated
  • Fix NRE in OnMouseWheel without EditingControlDataGridView
Microsoft Reviewers: Open in CodeFlow
@hughbe hughbe requested a review from dotnet/dotnet-winforms as a code owner Mar 17, 2020
@msftbot msftbot bot assigned hughbe Mar 17, 2020
@RussKie

This comment has been minimized.

Copy link
Member

RussKie commented Mar 18, 2020

Builds fails:

System\Windows\Forms\DataGridViewTextBoxEditingControlTests.cs(419,21): error CS0111: Type 'DataGridViewTextBoxEditingControlTests' already defines a member called 'DataGridViewTextBoxEditingDataGridViewTextBoxEditingControl_Text_Set_GetReturnsExpected' with the same parameter types [D:\a\1\s\src\System.Windows.Forms\tests\UnitTests\System.Windows.Forms.Tests.csproj]
##[error]System\Windows\Forms\DataGridViewTextBoxEditingControlTests.cs(419,21): error CS0111: Type 'DataGridViewTextBoxEditingControlTests' already defines a member called 'DataGridViewTextBoxEditingDataGridViewTextBoxEditingControl_Text_Set_GetReturnsExpected' with the same parameter types
@RussKie

This comment has been minimized.

Copy link
Member

RussKie commented Mar 18, 2020

Docs added dotnet/docs#17085

@hughbe hughbe force-pushed the hughbe:DataGridViewEditnigControl-tests branch 9 times, most recently from 404bf72 to c16c8c0 Mar 18, 2020
@hughbe hughbe force-pushed the hughbe:DataGridViewEditnigControl-tests branch from c16c8c0 to 262b684 Mar 20, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 21, 2020

Codecov Report

Merging #2983 into master will increase coverage by 0.19935%.
The diff coverage is 99.46809%.

@@                 Coverage Diff                 @@
##              master       #2983         +/-   ##
===================================================
+ Coverage   61.94595%   62.14530%   +0.19934%     
===================================================
  Files           1256        1257          +1     
  Lines         447545      449429       +1884     
  Branches       39209       39228         +19     
===================================================
+ Hits          277236      279299       +2063     
+ Misses        164844      164656        -188     
- Partials        5465        5474          +9     
Flag Coverage Δ
#Debug 62.14530% <99.46809%> (+0.19934%) ⬆️
#production 33.33981% <95.65217%> (+0.08196%) ⬆️
#test 98.97337% <100.00000%> (+0.00011%) ⬆️
@RussKie RussKie merged commit 8138af1 into dotnet:master Mar 21, 2020
5 checks passed
5 checks passed
WIP Ready for review
Details
dotnet-winforms CI Build #20200320.9 succeeded
Details
dotnet-winforms CI (Build Windows Debug) Build Windows Debug succeeded
Details
dotnet-winforms CI (Build Windows Release) Build Windows Release succeeded
Details
license/cla All CLA requirements met.
Details
@msftbot msftbot bot added this to the 5.0 milestone Mar 21, 2020
@hughbe hughbe deleted the hughbe:DataGridViewEditnigControl-tests branch Mar 21, 2020
M-Lipin added a commit to M-Lipin/winforms that referenced this pull request Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.