Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing template identity version information #2984

Closed

Conversation

@RussKie
Copy link
Member

RussKie commented Mar 18, 2020

Resolves #2981

Proposed changes

  • Fix the packages identities and add framework choices.

Customer Impact

Given that the identity lacked the version, the new template package targeting netcoreapp3.1 would supersede and replace the ones targeting netcoreapp3.0.

This breaks developer's ability to create app targeting netcoreapp3.x from command line (via dotnet new winforms) and rom VS (because the VS Template Engine Host will only install the highest versioned package for any given identity).

Regression?

  • Yes

Risk

  • Low. The change is to “dotnet new” templates only. No changes to Windows Forms runtime.
Microsoft Reviewers: Open in CodeFlow
Given that the identity lacked the version, the new template package
targeting netcoreapp3.1 would supersede and replace the ones targeting
netcoreapp3.0.

This breaks developer's ability to create app targeting netcoreapp3.x
from command line (via `dotnet new winforms`) and rom VS (because
the VS Template Engine Host will only install the highest versioned
package for any given identity).

Fix the packages identities and add framework choices.

Resolves #2981
@RussKie RussKie requested a review from dotnet/dotnet-winforms as a code owner Mar 18, 2020
@RussKie RussKie linked an issue that may be closed by this pull request Mar 18, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #2984 into release/3.1 will increase coverage by 0.00423%.
The diff coverage is n/a.

@@                  Coverage Diff                  @@
##           release/3.1       #2984         +/-   ##
=====================================================
+ Coverage     24.86688%   24.87111%   +0.00423%     
=====================================================
  Files              844         844                 
  Lines           260290      260290                 
  Branches         36896       36896                 
=====================================================
+ Hits             64726       64737         +11     
+ Misses          190841      190830         -11     
  Partials          4723        4723                 
Flag Coverage Δ
#Debug 24.87111% <ø> (+0.00423%) ⬆️
#production 24.87111% <ø> (+0.00423%) ⬆️
#test 100.00000% <ø> (ø)
@RussKie RussKie deleted the RussKie:fix_project_template_identities_31 branch Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.