Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move InvalidateRgn to Interop User32 #2987

Merged
merged 1 commit into from Mar 19, 2020
Merged

Conversation

@gpetrou
Copy link
Contributor

gpetrou commented Mar 18, 2020

Proposed changes

  • Move InvalidateRgn to Interop User32.
  • Replace some ExternDll usages with Libraries instead.
Microsoft Reviewers: Open in CodeFlow
@gpetrou gpetrou requested a review from dotnet/dotnet-winforms as a code owner Mar 18, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #2987 into master will increase coverage by 0.00166%.
The diff coverage is 100.00000%.

@@                 Coverage Diff                 @@
##              master       #2987         +/-   ##
===================================================
+ Coverage   61.55468%   61.55634%   +0.00166%     
===================================================
  Files           1255        1255                 
  Lines         444465      444466          +1     
  Branches       39010       39010                 
===================================================
+ Hits          273589      273597          +8     
+ Misses        165455      165436         -19     
- Partials        5421        5433         +12     
Flag Coverage Δ
#Debug 61.55634% <100.00000%> (+0.00166%) ⬆️
#production 33.03008% <100.00000%> (+0.00303%) ⬆️
#test 98.95847% <ø> (ø)
@hughbe
hughbe approved these changes Mar 18, 2020
@RussKie RussKie added the enhancement label Mar 18, 2020
@RussKie RussKie merged commit 3b8ddef into dotnet:master Mar 19, 2020
5 checks passed
5 checks passed
WIP Ready for review
Details
dotnet-winforms CI Build #20200318.3 succeeded
Details
dotnet-winforms CI (Build Windows Debug) Build Windows Debug succeeded
Details
dotnet-winforms CI (Build Windows Release) Build Windows Release succeeded
Details
license/cla All CLA requirements met.
Details
@msftbot msftbot bot added this to the 5.0 milestone Mar 19, 2020
M-Lipin added a commit to M-Lipin/winforms that referenced this pull request Mar 23, 2020
@gpetrou gpetrou deleted the gpetrou:InvalidateRgn branch Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.