Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fix for ListViewGroup footer #2991

Merged
merged 1 commit into from Mar 21, 2020
Merged

Conversation

@hughbe
Copy link
Contributor

hughbe commented Mar 19, 2020

Fixes #2970

Unconditionally set footer even if it is empty

Microsoft Reviewers: Open in CodeFlow
@hughbe hughbe requested a review from dotnet/dotnet-winforms as a code owner Mar 19, 2020
@msftbot msftbot bot assigned hughbe Mar 19, 2020
@hughbe hughbe force-pushed the hughbe:ListViewGroup-testFix branch 5 times, most recently from b79c9fa to 1953fa1 Mar 19, 2020
@RussKie

This comment has been minimized.

Copy link
Member

RussKie commented Mar 20, 2020

Do you think you could base it on #2988? This way we can see tests failing out in the open, and then see them being fixed.

@hughbe hughbe force-pushed the hughbe:ListViewGroup-testFix branch from 1953fa1 to 40fbe90 Mar 20, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 20, 2020

Codecov Report

Merging #2991 into master will increase coverage by 0.00312%.
The diff coverage is 100%.

@@                 Coverage Diff                 @@
##              master       #2991         +/-   ##
===================================================
+ Coverage   61.94595%   61.94908%   +0.00313%     
===================================================
  Files           1256        1256                 
  Lines         447545      447545                 
  Branches       39209       39208          -1     
===================================================
+ Hits          277236      277250         +14     
+ Misses        164844      164835          -9     
+ Partials        5465        5460          -5
Flag Coverage Δ
#Debug 61.94908% <100%> (+0.00312%) ⬆️
#production 33.25349% <100%> (-0.00436%) ⬇️
#test 98.98505% <100%> (+0.01179%) ⬆️
Copy link
Member

RussKie left a comment

🎉

@RussKie RussKie merged commit b044c87 into dotnet:master Mar 21, 2020
5 checks passed
5 checks passed
WIP Ready for review
Details
dotnet-winforms CI Build #20200320.2 succeeded
Details
dotnet-winforms CI (Build Windows Debug) Build Windows Debug succeeded
Details
dotnet-winforms CI (Build Windows Release) Build Windows Release succeeded
Details
license/cla All CLA requirements met.
Details
@msftbot msftbot bot added this to the 5.0 milestone Mar 21, 2020
@RussKie

This comment has been minimized.

Copy link
Member

RussKie commented Mar 21, 2020

Thank you

@hughbe hughbe deleted the hughbe:ListViewGroup-testFix branch Mar 21, 2020
M-Lipin added a commit to M-Lipin/winforms that referenced this pull request Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.